Remove checks for elements containing certain raw text and replace them with an is_displayed() check

RESOLVED WONTFIX

Status

Firefox OS
Gaia::UI Tests
RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: Martijn Wargers (zombie), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This came up in bug 1218895, comment 7.
"
The patch looks good to me. Following up on what we proposed during the meeting:
* we check the raw text in order to verify the input from the user (for instance a phone number put in the dialer, we verify it appears in the call log)
* we test the l10n-id for any string that comes from Gaia only (like an error message)
"

We should do this for example with this test:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_with_tour.py
This test has a lot of en-US strings, so naturally only works in en-US locale
(Reporter)

Updated

3 years ago
Assignee: nobody → martijn.martijn
(Reporter)

Updated

2 years ago
Blocks: 1237399
(Reporter)

Updated

2 years ago
Blocks: 1231979
(Reporter)

Updated

2 years ago
Blocks: 1231985
(Reporter)

Updated

2 years ago
Blocks: 1231988
Created attachment 8707013 [details] [review]
[gaia] mwargers:1219840 > mozilla-b2g:master
Martijn, I thought we were killing the Gip tests?
Flags: needinfo?(martijn.martijn)
(Reporter)

Updated

2 years ago
Attachment #8707013 - Flags: review?(npark)
Attachment #8707013 - Flags: review?(jlorenzo)
(Reporter)

Comment 3

2 years ago
Yes, that's the plan, wherever that's possible.
Flags: needinfo?(martijn.martijn)
Comment on attachment 8707013 [details] [review]
[gaia] mwargers:1219840 > mozilla-b2g:master

Nice changes! I don't see anything blocking in this PR.
Attachment #8707013 - Flags: review?(jlorenzo) → review+

Updated

2 years ago
Attachment #8707013 - Flags: review?(npark) → review+
(Reporter)

Comment 5

2 years ago
Comment on attachment 8707013 [details] [review]
[gaia] mwargers:1219840 > mozilla-b2g:master

Merged this: https://github.com/mozilla-b2g/gaia/commit/76517c1ea7acee620994f0af83feda4c1f185044

I'll leave this bug open, because this is basically about all of the tests and this pull request only handled a couple of tests.
I'll close the dependent bugs, though.
(Reporter)

Updated

2 years ago
Assignee: martijn.martijn → nobody
(Reporter)

Comment 6

2 years ago
Marking WONTFIX, sorry for the bug spam. If somebody still wants to work on this, please file a new bug for it.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.