1219840 - Remove checks for elements containing certain raw text and replace them with an is_displayed() check

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

This came up in bug 1218895, comment 7.
"
The patch looks good to me. Following up on what we proposed during the meeting:
* we check the raw text in order to verify the input from the user (for instance a phone number put in the dialer, we verify it appears in the call log)
* we test the l10n-id for any string that comes from Gaia only (like an error message)
"

We should do this for example with this test:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_with_tour.py
This test has a lot of en-US strings, so naturally only works in en-US locale

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1219840 > mozilla-b2g:master

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Martijn, I thought we were killing the Gip tests?

Comment 3

[Martijn Wargers (dead)]

Yes, that's the plan, wherever that's possible.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8707013 [details] [review]
[gaia] mwargers:1219840 > mozilla-b2g:master

Nice changes! I don't see anything blocking in this PR.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8707013 [details] [review]
[gaia] mwargers:1219840 > mozilla-b2g:master

Merged this: https://github.com/mozilla-b2g/gaia/commit/76517c1ea7acee620994f0af83feda4c1f185044

I'll leave this bug open, because this is basically about all of the tests and this pull request only handled a couple of tests.
I'll close the dependent bugs, though.

Comment 6

[Martijn Wargers (dead)]

Marking WONTFIX, sorry for the bug spam. If somebody still wants to work on this, please file a new bug for it.