1219853 - [email] Go back to mozAlarms instead of request-sync

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

Due to the issues uncovered while investigating bug 1213169, particularly bug 1213169 comment 12, for stability and reliability purposes we will switch the email app back to using mozAlarms directly for background sync instead of request-sync.

Comment 1

[James Burke [:jrburke]]

This will be like reverting the changes in bug 1098289.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Because of some races I discovered in bug 1213169 comment 13, I think we'll also want a fix like https://github.com/mozilla-b2g/gaia/compare/master...asutherland:email-keep-wakelocks-on-close?expand=1 in here.

As I note in the commit comment there, I expect things to be better withou the fix under mozAlarms (where we'd end up only syncing every other time the mozAlarms fires) versus requestsync (where we basically break forever until the user manually triggers the app), but it still seems worth pursuing the workaround/fix.

I'll also try and raise appropriate system bugs so that the system message process does not have this failure mode.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia-email-libs-and-more] jrburke:bug1219853-email-alarm-sync > mozilla-b2g:master

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1219853-email-alarm-sync > mozilla-b2g:master

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8681457 [details] [review]
[gaia-email-libs-and-more] jrburke:bug1219853-email-alarm-sync > mozilla-b2g:master

GELAM review

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8681458 [details] [review]
[gaia] jrburke:bug1219853-email-alarm-sync > mozilla-b2g:master

Gaia review

Comment 7

[James Burke [:jrburke]]

Merged in GELAM master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/49a31b022af5811a6d985e3f62d5c7a2f1307221

Merged in Gaia master:
https://github.com/mozilla-b2g/gaia/commit/ec142cec0082d8cec1932e8bdb9585d59f2dfb0a

Comment 8

[Dylan Oliver [:doliver]]

triage: need this in 2.5 for reliable email sync.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

(This is in v2.5 despite when it landed.)