Closed Bug 1219854 Opened 9 years ago Closed 9 years ago

Handle non-URIs in memory heap view

Categories

(DevTools :: Memory, defect)

Product:
DevTools
Component:
Memory
Version:
43 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jsantell, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

Add more robust source name parsing for displaying allocation stack tree items
6.94 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
Should just render this simply, like "self-hosted" or an "eval" site.

@@redux/middleware/task#error threw an exception: Error: malformed URI: self-hosted
Stack: newURI@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/url.js:35:1
URL@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/url.js:97:13
render@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/memory/components/frame.js:20:15
[38]</ReactCompositeComponentMixin._renderValidatedComponentWithoutOwnerOrContext@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:6324:29
[38]</ReactCompositeComponentMixin._renderValidatedComponent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:6344:27
[78]</ReactPerf.measure/wrapper@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react.js:12828:16
[38]</ReactCompositeComponentMixin.mountComponent@resource://gre/m
Attachment #8680899 - Flags: review?(jsantell) → review+
Attachment #8680899 - Attachment is obsolete: true
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/2df19018183b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: