1219861 - Remove not-allowed cursor on disabled buttons on in-content pages

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Brian Grinstead [:bgrins]]

There is a not-allowed cursor for disabled buttons that we are overriding for the aboutCertError page.  There was a suggestion in Bug 1207107 to remove the rule causing this instead of doing the override.  From https://bugzilla.mozilla.org/show_bug.cgi?id=1207107#c17:

>+/* Pressing the retry button will cause the cursor to flicker from a pointer to
>+ * not-allowed. Override the disabled cursor behaviour since we will never show
>+ * the button disabled as the initial state. */
>+button:disabled {
>   cursor: pointer;
> }

Can we just remove <http://hg.mozilla.org/mozilla-central/annotate/fc706d376f06/toolkit/themes/shared/in-content/common.inc.css#l213>?

Disabled buttons using the not-allowed cursor is unusual and therefore seems more distracting than useful.

Comment 1

[Shivam]

Hey i want to work on this bug , i have the build environment , can u guide me further on how to reproduce the bug and find the problem

Comment 2

[Dão Gottwald [:dao]]

(In reply to Shivam from comment #1)
> Hey i want to work on this bug , i have the build environment , can u guide
> me further on how to reproduce the bug and find the problem

You can reproduce this by going to about:preferences#search for instance and moving the mouse cursor over one of the disabled buttons. The cursor changes to the not-allowed icon, and it shouldn't do that.

Comment 3

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev1 - bug1219861_cursorchanges.diff

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8684615 [details] [diff] [review]
rev1 - bug1219861_cursorchanges.diff

Looks good, but also remove this rule please:

http://hg.mozilla.org/mozilla-central/annotate/e2a910c048dc/browser/themes/shared/aboutCertError.css#l56

Comment 5

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev2 - bug1219861_cursorchanges.diff

I removed the extra space for consistency. Is that OK?

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8684622 [details] [diff] [review]
rev2 - bug1219861_cursorchanges.diff

(In reply to Boris Kudryavtsev [:bkudryavtsev] from comment #5)
> Created attachment 8684622 [details] [diff] [review]
> rev2 - bug1219861_cursorchanges.diff
> 
> I removed the extra space for consistency. Is that OK?

Yep, thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7d84f19e270e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d84f19e270e