Intermittent browser_markupview_dragdrop_autoscroll.js | The view was scrolled down - | The view was scrolled up -

RESOLVED FIXED in Firefox 45

Status

RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: KWierso, Assigned: sjakthol)

Tracking

({intermittent-failure})

unspecified
Firefox 45
intermittent-failure

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 5

3 years ago
Created attachment 8690492 [details]
MozReview Request: Bug 1219953 - Consider Markup View autoscroll finished only if the view has not scrolled for 30 consecutive frames. r?pbrosset

Bug 1219953 - Consider Markup View autoscroll finished only if the view has not scrolled for 30 consecutive frames. r?pbrosset

Waiting for 50ms and checking if the scrollTop has changed does not
necessarily mean that the scrolling has stopped (or even started). It
might also mean that a GC has blocked the autoscroll interval from
running and the scrolling will happen in a few moments. If the view
hasn't even started to scroll, the assertion that the view has scrolled
fails. If the view has started to scroll, the next call to
waitForViewScroll() might resolve when before the direction of the
scrolling is reversed causing the assertions that the direction has
changed to fail.

Instead of relying on intervals to detect if scrolling has stopped, the
test could wait for a certain number of frames during which the view
has not scrolled to determine if the scrolling has ended. This method has
successfully been used in layout/base/tests/test_scroll_snapping.html
to detect when scrolling has stopped.

These changes make browser_markupview_dragdrop_autoscroll.js to use the
previously presented method to detect the end of markup-view autoscroll.
The code used in the layout test has been included in the test and
modified to yield and use promises when waiting for a frame.
Attachment #8690492 - Flags: review?(pbrosset)
(Assignee)

Comment 6

3 years ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=34ae04ee1f81

The changes should fix bug 1219490 too.
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Comment hidden (Intermittent Failures Robot)
Attachment #8690492 - Flags: review?(pbrosset) → review+
Comment on attachment 8690492 [details]
MozReview Request: Bug 1219953 - Consider Markup View autoscroll finished only if the view has not scrolled for 30 consecutive frames. r?pbrosset

https://reviewboard.mozilla.org/r/25867/#review23299

Really nice. Thanks.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fc6459ef44a4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.