Closed Bug 1219963 Opened 4 years ago Closed 4 years ago

Intermittent test_get_last_visited.html | Last visited timestamp is before present

Categories

(Core :: DOM: Push Notifications, defect)

44 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: KWierso, Assigned: nalexander)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Flags: needinfo?(nalexander)
Hmm.  I was very careful to find an event that happened after the DB write, so this surprises me.

I wonder if we're receiving two 'link-visited' notifications, and seeing an update after the first notification but before we read from the DB?  I will investigate and try to add test logging to see if this is true.

Keeping the NI as a reminder.
Depends on: 1214366
Clearing NI.  We can re-open this ticket if this hasn't addressed the intermittents.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Flags: needinfo?(nalexander)
https://hg.mozilla.org/mozilla-central/rev/894843a94668
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Boy I long for the days when RyanVM noticed every testonly fix and landed it on affected release branches.
Flags: needinfo?(philringnalda)
Approval Request Comment
[Feature/regressing bug #]: 1214366.
[User impact if declined]: none.  This is a test uplift.
[Describe test coverage new/current, TreeHerder]: Test only.
[Risks and why]: Very low.  Test only, intermittents squashed on Nightly and Aurora.
[String/UUID change made/needed]: none.
Flags: needinfo?(philringnalda)
Attachment #8700684 - Flags: approval-mozilla-beta?
Comment on attachment 8700684 [details] [diff] [review]
Patch that is currently on mozilla-{central,aurora}

Test-only changes don't need relman approval.
Attachment #8700684 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.