Closed Bug 1219965 Opened 9 years ago Closed 8 years ago

Check the Firefox version in the Sync and FxA telemetry tests

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file)

...So we don't break Firefox 46 in 6 weeks.
Flags: firefox-backlog+
Priority: -- → P1
There may be some probes we can remove. :-) But this wraps them all in a version check.
Attachment #8681582 - Flags: feedback?(markh)
Comment on attachment 8681582 [details] [diff] [review]
0001-Bug-1219965-Check-the-Firefox-version-in-the-Sync-an.patch

Review of attachment 8681582 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Kit, but I don't think spreading that version number around is the right thing to do. Do you think we can try/catch around the getHistogramById() function, catching the specific exception for it not existing, then printing a warning and skipping the test itself?
Depends on: 1221262
Comment on attachment 8681582 [details] [diff] [review]
0001-Bug-1219965-Check-the-Firefox-version-in-the-Sync-an.patch

Review of attachment 8681582 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing feedback request as I think the approach using bug 1221262 is the way to go...
Attachment #8681582 - Flags: feedback?(markh)
Just pruning outstanding bugs...
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: