1219991 - make RestyleManager::{Begin,End}ProcessingRestyles private

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

The only callers of these two methods are RestyleTracker, which is a friend of RestyleManager, so let's just make them private.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8680961 [details] [diff] [review]
patch

r=me

Comment 3

[Daniel Holbert [:dholbert]]

(Tangent/speculation: I wonder if we should really be using an RAII object to make these {Begin|End}ProcessingRestyles calls?

Maybe it's not worth it, since they're only called once -- from RestyleTracker::DoProcessRestyles(). Still, if we added an early-return in between the calls for some reason, we'd probably get into trouble from forgetting to call EndProcessingRestyles before the return -- and an RAII object would save us from that.)

Comment 4

[Cameron McCormack (:heycam)]

Yes, although it looks like it would be tricky to do that with the RAII ReframingStyleContexts being used there too, as the two scopes wouldn't nest.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/198cb59335e7

Comment 6

[Daniel Holbert [:dholbert]]

Oh, right -- I missed that BeginProcessingRestyles is called in a different scope from EndProcessingRestyles there. Never mind for now, I suppose.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/198cb59335e7

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/198cb59335e7

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion