Closed
Bug 1220004
Opened 9 years ago
Closed 9 years ago
fix mozInnerScreenX/Y usage in apz test utils
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
mozInnerScreenX/Y is in CSS pixels, but the apz test utils use it like it is in dev pixels. This causes the test to fail when run on my retina macbook pro for example.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8680988 -
Flags: review?(botond)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8680988 [details] [diff] [review] patch Review of attachment 8680988 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this!
Attachment #8680988 -
Flags: review?(botond) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3adbfe011e8f
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aed3459daf4a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
|
||
Comment 6•9 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/aed3459daf4a
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 7•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•