1220033 - Modern.ie MSE demo stalls

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Microsoft's demo at https://dev.modern.ie/testdrive/demos/eme/ stalls on the unencrypted Big Buck Bunny demo. I tested in Beta 42, Windows 7.

STR:
1. Open https://dev.modern.ie/testdrive/demos/eme/
2. Select the unencrypted Big Buck Bunny video.
3. Start it playing, and play around with the bitrate slider at the bottom, eventually playback still stall.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Don't use fuzz arithmetic for calculating internal buffered ranges

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/849e4c4784ca

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/849e4c4784ca

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d06197eaef02

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8682895 [details] [diff] [review]
Don't use fuzz arithmetic for calculating internal buffered ranges

Approval Request Comment
[Feature/regressing bug #]: 1220033
[User impact if declined]: Site using MSE may stall
[Describe test coverage new/current, TreeHerder]: In central for a week
[Risks and why]: Low. It's the proper thing to do.
[String/UUID change made/needed]: None

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8682895 [details] [diff] [review]
Don't use fuzz arithmetic for calculating internal buffered ranges

Prevents a video hang, let's take this for aurora and beta.

Comment 8

[alex_mayorga]

Attachment: bug-1219473.PNG

¡Hola Jean-Yves!

Ended up here from https://bugzilla.mozilla.org/show_bug.cgi?id=1219473

The steps on that bug no longer cause the playback to stop on Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151110030205 CSet: cc473fe5dc512c450634506f68cbacfb40a06a23 so I'm marking this verified.

There's still the error "TypeError: video.error is null" being shown at the top the page and a bit of weird artifacting on the bottom part of the video (please see bug-1219473.PNG attached).

Shall I file separate bugs for these or are these known already?

¡Gracias!
Alex

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d06197eaef02

Comment 10

[Jean-Yves Avenard [:jya]]

(In reply to alex_mayorga from comment #8)

> Shall I file separate bugs for these or are these known already?

This is likely the same as bug 1222201, and there's another.

I'll look into those shortly

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fcbbc5261056

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/84b0b59ed1d2

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fcbbc5261056

Comment 14

[Andrei Vaida [:avaida]]

Updating Fx45 flag per Comment 8. Setting [qe-verify+] for verification on 43b3.

Comment 15

[Mihai Boldan, QA [:mboldan]]

Reproduced with 43.0b2 under Windows 7 x64. 
Still reproducible with 43.0b3 build 2 (Build ID: 20151112144305), under Windows 7 64-bit and Windows 10x32
Browser console output:
- ‘setting 'encrypted' event listener’ thrown by demo.js:451:13
- ‘Setting src: [object MediaSource]’ thrown by demo.js:412:13

Jean-Yves, any ideas why? Should I reopen this bug or file a different one?

Comment 16

[Jean-Yves Avenard [:jya]]

Only the first stream can work. The others are EME using CDM we don't support.

But you're right I can reproduce it on beta and aurora too....

need to check what was uplifted and it's missing anyting

Comment 17

[Jean-Yves Avenard [:jya]]

oh I see... it's the wrong patch that was uplifted. Well, right path but wrong bug number.

Tomcat, it's this patch that need uplifting

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This already landed on aurora in http://hg.mozilla.org/releases/mozilla-aurora/rev/d05eb25b0baa as far as I can tell.

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6fa2e5fb632

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d05eb25b0baa

Comment 21

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

I reproduced the initial issue using an old build (Firefox 43 beta 2), verified that the issue does not reproduce anymore using Firefox 43 beta 4 and latest Firefox Developer Edition 44.0a2 on Windows 7 64-bit and Windows 10 64-bit.