1220054 - [TV Browser] Please change the font size or line spacing for Bookmarks

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P4)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: Screen Shot

Please change the font size or line spacing for Bookmarks.

Actual results:
 - Please see the attachment

Expected results:
 － 書籤工具列

Comment 1

[Evelyn Hung]

UI polish. The line space isn't large enough for Chinese words.
Dan, could you fix here? Thanks.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:122054_update_bookmark_title_line_height > mozilla-b2g:master

Comment 3

[Dan Huang[:danhuang]]

Comment on attachment 8702826 [details] [review]
[gaia] danhuang1202:122054_update_bookmark_title_line_height > mozilla-b2g:master

Hi Yi-Fan, please help review. This patch remove line-height style to fix this bug. Thanks.

Comment 4

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/011d73ff83a02623e8840c2263ad0b40ff8e8149

Comment 5

[Dan Huang[:danhuang]]

Comment on attachment 8702826 [details] [review]
[gaia] danhuang1202:122054_update_bookmark_title_line_height > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1190158
[User impact] if declined:The bookmark title in chinese would be cut off
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=59ad5e0974c17846ea78880f7e88fc78d2f1ddc4
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 6

[Josh Cheng [:josh]]

Comment on attachment 8702826 [details] [review]
[gaia] danhuang1202:122054_update_bookmark_title_line_height > mozilla-b2g:master

Approved for TV 2.5

Comment 7

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/cf4538d7300afcde61f8d07be3b88292ba30c515

Comment 8

[Rid Pan]

Verify this issue on the latest build.
The font of Chinese words and the line spacing for Bookmarks can shows correctly in the bookmarks page.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

[Build Info]
Environment: Simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec