1220071 - Statusbar background is wrong in Pin dialog when in landscape

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Open the Browser and navigate to any web site
2.- Open the pin dialog
3.- Switch to landscape

Expected:

The satusbar background is not transparent

Actual:

The satusbar background is transparent

Comment 1

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Broken UI

Comment 2

[Alberto Pastor [:albertopq]]

Bisecting, looks like a regression from bug 1218439

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1220071-statusbar-bg > mozilla-b2g:master

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8681195 [details] [review]
[gaia] albertopq:1220071-statusbar-bg > mozilla-b2g:master

bug 1218439 renamed the orientationchange events, but didn't rename the listeners to the internal event. Etienne, could you please take a look?

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8681195 [details] [review]
[gaia] albertopq:1220071-statusbar-bg > mozilla-b2g:master

keeping a trace of the IRC conversation: we rolled back the "internal" appwindow event to orientationchange. It won't conflict with the gecko stuff since it's "_" prefixed and very AppWindow specific (we never dispatch them on the window)

Comment 6

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/a91f01f1734ddaf5700b211fe2ec6689886b3952

Comment 7

[Alison Shiue]

Verified on

[Flame]
Build ID               20151102150204
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6275cd9c71b76891f6b6585dabc687bc443ab877
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.182914
Firmware Date          Mon Nov  2 18:29:28 EST 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151103000930
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9f69202d82752e093a653a8f15b0274e347db33a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151102.233051
Firmware Date          Mon Nov  2 23:30:58 UTC 2015
Bootloader             s1