Closed Bug 1220122 Opened 9 years ago Closed 9 years ago

Show visual feedback and disable 'Get Started' button while enabling Sync

Categories

(Firefox OS Graveyard :: Sync, defect, P2)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file)

[gaia] ferjm:bug1220122.enabling.ui.feedback > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
Same as bug 1215459 but for the phone.
Blocks: fxos-sync
Target Milestone: --- → FxOS-S11 (13Nov)
Assignee: nobody → ferjmoreno
Priority: -- → P2
Attachment #8683760 - Flags: review?(yzenevich)
My phone seems to be stuck on the enabling screen (last message received is enabling):

STRs:

* Go to settings
* Go to firefox sync
* Press log in
* Log in into firefox accounts (i first used the new one)
* Activate a new firefox account
* (not sure if i had to press log in to sync again) but the final state is enabling screen with Signing in... button being disabled (*).

Couple of additional steps:
* I then went to firefox accounts, and logged out
* Went back to sync but the screen remained the same (*).
* I think closed settings app and started it again
* Went back to sync but the screen again remained the same (*).




Fred:
Just wanted to run by you the use of expect in unit tests as we haven't been using it before.
Flags: needinfo?(gasolin)
Flags: needinfo?(ferjmoreno)
Hello Yura,

I am afraid that I cannot reproduce the issue with the STR that you describe:

(In reply to Yura Zenevich [:yzen] from comment #2)
> My phone seems to be stuck on the enabling screen (last message received is
> enabling):
> 
> STRs:
> 
> * Go to settings
> * Go to firefox sync
> * Press log in
> * Log in into firefox accounts (i first used the new one)

If this is a new account, you should see a dialog telling you the following:

"You need to activate Firefox Sync on Desktop or Android first and then try again."

Closing this dialog should take you to the "Get Started" screen and the button should say "Get Started".

> * Activate a new firefox account

I guess by activating you mean that you went to your Desktop, verified the FxA email and logged in in Sync.

> * (not sure if i had to press log in to sync again) but the final state is

Yes, you have to go to the "Get Started" screen and click on the "Get Started" button. That should show "Signing in..." for a few seconds (depending on how fast your connection is) and eventually the logged in screen.

> enabling screen with Signing in... button being disabled (*).

Note that this can take a few seconds. We need to check that your account is valid against the Firefox Sync server, so there are a few network requests involved.

> 
> Couple of additional steps:
> * I then went to firefox accounts, and logged out
> * Went back to sync but the screen remained the same (*).

This looks like a different issue. Somehow you got stuck in the 'enabling' state and we don't consider the option of logging out from FxA during that state. I'll file a new bug for that.

> * I think closed settings app and started it again
> * Went back to sync but the screen again remained the same (*).
> 

It seems that you got stuck on 'enabling' somehow.

Could you try to reproduce this again with SyncManager debug enabled [1], please?

[1] https://mxr.mozilla.org/gaia/source/apps/system/js/sync_manager.js#125
Flags: needinfo?(ferjmoreno) → needinfo?(yzenevich)
Hi Fernando, more details (with debugging enabled):

My steps:

* go to settings
* go to sync
* press get started
* get a prompt to create Firefox account
* go through the steps to create it
* Observed: dialog that says i need to activate the account on other platform
* activated account on desktop
* in sync log in page press get started again
* Observed: continue seeing the same dialog over and over again.

Full log here:

[SyncManager][317620.605] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317625.114] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317625.120] handling onsyncenabling base_module.js:605:1
[SyncManager][317625.123] onsyncenabling observed base_module.js:605:1
[SyncManager][317625.133] Setting state,enabling base_module.js:605:1
[SyncManager][317625.182] Preference change,[object Object] base_module.js:605:1
TypeError: this.app.getBottomMostWindow is not a function
 value_selector.js:338:9
[SyncManager][317731.632] handling appterminated base_module.js:605:1
[SyncManager][317733.577] handling appterminated base_module.js:605:1
Could not enable sync UNVERIFIED_ACCOUNT sync_manager.js:334:9

[SyncManager][317734.101] handling onsyncerrored base_module.js:605:1
[SyncManager][317734.104] onsyncerrored observed base_module.js:605:1
[SyncManager][317734.108] Setting state,errored base_module.js:605:1
[SyncManager][317734.116] Unrecoverable error base_module.js:605:1
[SyncManager][317734.119] handling onsyncdisabling base_module.js:605:1
[SyncManager][317734.121] onsyncdisabling observed base_module.js:605:1
[SyncManager][317734.123] Setting state,disabling base_module.js:605:1
[SyncManager][317734.126] Saving user settings base_module.js:605:1
[SyncManager][317734.252] Saving setting,null.sync.collections.passwords.enabled,false base_module.js:605:1
[SyncManager][317734.259] Saving setting,null.sync.scheduler.wifionly,false base_module.js:605:1
[SyncManager][317734.264] Saving setting,null.sync.collections.bookmarks.readonly,true base_module.js:605:1
[SyncManager][317734.267] Saving setting,null.sync.collections.bookmarks.enabled,false base_module.js:605:1
[SyncManager][317734.270] Saving setting,null.sync.fxa.audience,https://token.services.mozilla.com/ base_module.js:605:1
[SyncManager][317734.273] Saving setting,null.sync.server.url,https://syncto.dev.mozaws.net/v1/ base_module.js:605:1
[SyncManager][317734.275] Saving setting,null.sync.scheduler.interval,3600 base_module.js:605:1
[SyncManager][317734.278] Saving setting,null.sync.collections.history.enabled,true base_module.js:605:1
[SyncManager][317734.281] Saving setting,null.sync.collections.history.readonly,true base_module.js:605:1
[SyncManager][317734.283] Saving setting,null.sync.collections.passwords.readonly,true base_module.js:605:1
[SyncManager][317734.319] Restoring default settings base_module.js:605:1
[SyncManager][317734.348] Restoring setting sync.collections.history.enabled, base_module.js:605:1
[SyncManager][317734.350] Restoring setting sync.collections.passwords.enabled, base_module.js:605:1
[SyncManager][317734.351] Restoring setting sync.collections.bookmarks.enabled, base_module.js:605:1
[SyncManager][317734.353] Restoring setting sync.collections.history.readonly, base_module.js:605:1
[SyncManager][317734.355] Restoring setting sync.collections.passwords.readonly, base_module.js:605:1
[SyncManager][317734.358] Restoring setting sync.collections.bookmarks.readonly, base_module.js:605:1
[SyncManager][317734.359] Restoring setting sync.server.url, base_module.js:605:1
[SyncManager][317734.362] Restoring setting sync.scheduler.interval, base_module.js:605:1
[SyncManager][317734.364] Restoring setting sync.scheduler.wifionly, base_module.js:605:1
[SyncManager][317734.366] Restoring setting sync.fxa.audience, base_module.js:605:1
[SyncManager][317734.368] handling onsyncdisabled base_module.js:605:1
[SyncManager][317734.370] onsyncdisabled observed base_module.js:605:1
[SyncManager][317734.371] Setting state,disabled base_module.js:605:1
Could not unregister sync task UnknownTaskError disabled sync_manager.js:538:1
[SyncManager][317734.425] Preference change,[object Object] base_module.js:605:1
[SyncManager][317753.829] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317753.843] handling onsyncenabling base_module.js:605:1
[SyncManager][317753.849] onsyncenabling observed base_module.js:605:1
[SyncManager][317753.857] Setting state,enabling base_module.js:605:1
[SyncManager][317753.910] Preference change,[object Object] base_module.js:605:1
Could not enable sync UNVERIFIED_ACCOUNT sync_manager.js:334:9

[SyncManager][317753.941] handling onsyncerrored base_module.js:605:1
[SyncManager][317753.943] onsyncerrored observed base_module.js:605:1
[SyncManager][317753.946] Setting state,errored base_module.js:605:1
[SyncManager][317753.949] Unrecoverable error base_module.js:605:1
[SyncManager][317753.952] handling onsyncdisabling base_module.js:605:1
[SyncManager][317753.968] onsyncdisabling observed base_module.js:605:1
[SyncManager][317753.975] Setting state,disabling base_module.js:605:1
[SyncManager][317753.978] Saving user settings base_module.js:605:1
[SyncManager][317754.029] Setting value already saved,sync.scheduler.interval base_module.js:605:1
[SyncManager][317754.032] Setting value already saved,sync.collections.passwords.enabled base_module.js:605:1
[SyncManager][317754.035] Setting value already saved,sync.collections.history.enabled base_module.js:605:1
[SyncManager][317754.038] Setting value already saved,sync.collections.history.readonly base_module.js:605:1
[SyncManager][317754.041] Setting value already saved,sync.server.url base_module.js:605:1
[SyncManager][317754.044] Setting value already saved,sync.collections.bookmarks.readonly base_module.js:605:1
[SyncManager][317754.046] Setting value already saved,sync.scheduler.wifionly base_module.js:605:1
[SyncManager][317754.049] Setting value already saved,sync.collections.bookmarks.enabled base_module.js:605:1
[SyncManager][317754.051] Setting value already saved,sync.collections.passwords.readonly base_module.js:605:1
[SyncManager][317754.053] Setting value already saved,sync.fxa.audience base_module.js:605:1
[SyncManager][317754.055] Restoring default settings base_module.js:605:1
[SyncManager][317754.086] Restoring setting sync.collections.history.enabled, base_module.js:605:1
[SyncManager][317754.088] Restoring setting sync.collections.passwords.enabled, base_module.js:605:1
[SyncManager][317754.090] Restoring setting sync.collections.bookmarks.enabled, base_module.js:605:1
[SyncManager][317754.092] Restoring setting sync.collections.history.readonly, base_module.js:605:1
[SyncManager][317754.094] Restoring setting sync.collections.passwords.readonly, base_module.js:605:1
[SyncManager][317754.096] Restoring setting sync.collections.bookmarks.readonly, base_module.js:605:1
[SyncManager][317754.097] Restoring setting sync.server.url, base_module.js:605:1
[SyncManager][317754.099] Restoring setting sync.scheduler.interval, base_module.js:605:1
[SyncManager][317754.101] Restoring setting sync.scheduler.wifionly, base_module.js:605:1
[SyncManager][317754.103] Restoring setting sync.fxa.audience, base_module.js:605:1
[SyncManager][317754.106] handling onsyncdisabled base_module.js:605:1
[SyncManager][317754.108] onsyncdisabled observed base_module.js:605:1
[SyncManager][317754.110] Setting state,disabled base_module.js:605:1
Could not unregister sync task UnknownTaskError disabled sync_manager.js:538:1
[SyncManager][317754.381] Preference change,[object Object] base_module.js:605:1
[SyncManager][317756.040] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317756.050] handling onsyncenabling base_module.js:605:1
[SyncManager][317756.054] onsyncenabling observed base_module.js:605:1
[SyncManager][317756.057] Setting state,enabling base_module.js:605:1
[SyncManager][317756.102] Preference change,[object Object] base_module.js:605:1
Error trying sync invalid account sync_manager.js:670:11

Could not enable sync invalid account sync_manager.js:334:9

[SyncManager][317761.823] handling onsyncerrored base_module.js:605:1
[SyncManager][317761.826] onsyncerrored observed base_module.js:605:1
[SyncManager][317761.829] Setting state,errored base_module.js:605:1
[SyncManager][317761.831] Unrecoverable error base_module.js:605:1
[SyncManager][317761.833] handling onsyncdisabling base_module.js:605:1
[SyncManager][317761.835] onsyncdisabling observed base_module.js:605:1
[SyncManager][317761.836] Setting state,disabling base_module.js:605:1
[SyncManager][317761.839] Saving user settings base_module.js:605:1
[SyncManager][317761.872] handling appterminated base_module.js:605:1
[SyncManager][317761.918] Setting value already saved,sync.collections.history.readonly base_module.js:605:1
[SyncManager][317761.920] Setting value already saved,sync.collections.history.enabled base_module.js:605:1
[SyncManager][317761.922] Setting value already saved,sync.server.url base_module.js:605:1
[SyncManager][317761.924] Setting value already saved,sync.scheduler.wifionly base_module.js:605:1
[SyncManager][317761.926] Setting value already saved,sync.collections.passwords.enabled base_module.js:605:1
[SyncManager][317761.935] Setting value already saved,sync.collections.bookmarks.enabled base_module.js:605:1
[SyncManager][317761.938] Setting value already saved,sync.collections.bookmarks.readonly base_module.js:605:1
[SyncManager][317761.941] Setting value already saved,sync.fxa.audience base_module.js:605:1
[SyncManager][317761.946] Setting value already saved,sync.scheduler.interval base_module.js:605:1
[SyncManager][317761.948] Setting value already saved,sync.collections.passwords.readonly base_module.js:605:1
[SyncManager][317761.950] Restoring default settings base_module.js:605:1
[SyncManager][317761.985] Restoring setting sync.collections.history.enabled, base_module.js:605:1
[SyncManager][317761.987] Restoring setting sync.collections.passwords.enabled, base_module.js:605:1
[SyncManager][317761.989] Restoring setting sync.collections.bookmarks.enabled, base_module.js:605:1
[SyncManager][317761.991] Restoring setting sync.collections.history.readonly, base_module.js:605:1
[SyncManager][317761.992] Restoring setting sync.collections.passwords.readonly, base_module.js:605:1
[SyncManager][317761.994] Restoring setting sync.collections.bookmarks.readonly, base_module.js:605:1
[SyncManager][317761.996] Restoring setting sync.server.url, base_module.js:605:1
[SyncManager][317761.998] Restoring setting sync.scheduler.interval, base_module.js:605:1
[SyncManager][317762.000] Restoring setting sync.scheduler.wifionly, base_module.js:605:1
[SyncManager][317762.002] Restoring setting sync.fxa.audience, base_module.js:605:1
[SyncManager][317762.004] handling onsyncdisabled base_module.js:605:1
[SyncManager][317762.005] onsyncdisabled observed base_module.js:605:1
[SyncManager][317762.007] Setting state,disabled base_module.js:605:1
Could not unregister sync task UnknownTaskError disabled sync_manager.js:538:1
[SyncManager][317762.155] Preference change,[object Object] base_module.js:605:1
[SyncManager][317771.438] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317772.040] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317772.044] handling onsyncenabling base_module.js:605:1
[SyncManager][317772.056] onsyncenabling observed base_module.js:605:1
[SyncManager][317772.059] Setting state,enabling base_module.js:605:1
[SyncManager][317772.119] Preference change,[object Object] base_module.js:605:1
[SyncManager][317774.947] handling appterminated base_module.js:605:1
Error trying sync invalid account sync_manager.js:670:11

Could not enable sync invalid account sync_manager.js:334:9

[SyncManager][317774.961] handling onsyncerrored base_module.js:605:1
[SyncManager][317774.963] onsyncerrored observed base_module.js:605:1
[SyncManager][317774.966] Setting state,errored base_module.js:605:1
[SyncManager][317774.968] Unrecoverable error base_module.js:605:1
[SyncManager][317774.971] handling onsyncdisabling base_module.js:605:1
[SyncManager][317775.005] onsyncdisabling observed base_module.js:605:1
[SyncManager][317775.009] Setting state,disabling base_module.js:605:1
[SyncManager][317775.013] Saving user settings base_module.js:605:1
[SyncManager][317775.219] Saving setting,yz11@mailinator.com.sync.fxa.audience,https://token.services.mozilla.com/ base_module.js:605:1
[SyncManager][317775.224] Saving setting,yz11@mailinator.com.sync.collections.passwords.readonly,true base_module.js:605:1
[SyncManager][317775.228] Saving setting,yz11@mailinator.com.sync.collections.history.readonly,true base_module.js:605:1
[SyncManager][317775.236] Saving setting,yz11@mailinator.com.sync.collections.bookmarks.readonly,true base_module.js:605:1
[SyncManager][317775.241] Saving setting,yz11@mailinator.com.sync.server.url,https://syncto.dev.mozaws.net/v1/ base_module.js:605:1
[SyncManager][317775.244] Saving setting,yz11@mailinator.com.sync.scheduler.interval,3600 base_module.js:605:1
[SyncManager][317775.247] Saving setting,yz11@mailinator.com.sync.collections.history.enabled,true base_module.js:605:1
[SyncManager][317775.250] Saving setting,yz11@mailinator.com.sync.collections.bookmarks.enabled,false base_module.js:605:1
[SyncManager][317775.256] Saving setting,yz11@mailinator.com.sync.collections.passwords.enabled,false base_module.js:605:1
[SyncManager][317775.258] Saving setting,yz11@mailinator.com.sync.scheduler.wifionly,false base_module.js:605:1
[SyncManager][317775.282] Restoring default settings base_module.js:605:1
[SyncManager][317775.337] Restoring setting sync.collections.history.enabled, base_module.js:605:1
[SyncManager][317775.341] Restoring setting sync.collections.passwords.enabled, base_module.js:605:1
[SyncManager][317775.344] Restoring setting sync.collections.bookmarks.enabled, base_module.js:605:1
[SyncManager][317775.346] Restoring setting sync.collections.history.readonly, base_module.js:605:1
[SyncManager][317775.348] Restoring setting sync.collections.passwords.readonly, base_module.js:605:1
[SyncManager][317775.350] Restoring setting sync.collections.bookmarks.readonly, base_module.js:605:1
[SyncManager][317775.361] Restoring setting sync.server.url, base_module.js:605:1
[SyncManager][317775.364] Restoring setting sync.scheduler.interval, base_module.js:605:1
[SyncManager][317775.367] Restoring setting sync.scheduler.wifionly, base_module.js:605:1
[SyncManager][317775.370] Restoring setting sync.fxa.audience, base_module.js:605:1
[SyncManager][317775.376] handling onsyncdisabled base_module.js:605:1
[SyncManager][317775.391] onsyncdisabled observed base_module.js:605:1
[SyncManager][317775.395] Setting state,disabled base_module.js:605:1
Could not unregister sync task UnknownTaskError disabled sync_manager.js:538:1
[SyncManager][317775.493] Preference change,[object Object] base_module.js:605:1
[SyncManager][317777.896] handling iac-gaia-sync-management base_module.js:605:1
[SyncManager][317777.898] handling onsyncenabling base_module.js:605:1
[SyncManager][317777.900] onsyncenabling observed base_module.js:605:1
[SyncManager][317777.902] Setting state,enabling base_module.js:605:1
[SyncManager][317777.950] Preference change,[object Object] base_module.js:605:1
Error trying sync invalid account sync_manager.js:670:11

Could not enable sync invalid account sync_manager.js:334:9

[SyncManager][317780.671] handling onsyncerrored base_module.js:605:1
[SyncManager][317780.672] onsyncerrored observed base_module.js:605:1
[SyncManager][317780.678] Setting state,errored base_module.js:605:1
[SyncManager][317780.680] Unrecoverable error base_module.js:605:1
[SyncManager][317780.682] handling onsyncdisabling base_module.js:605:1
[SyncManager][317780.684] onsyncdisabling observed base_module.js:605:1
[SyncManager][317780.685] Setting state,disabling base_module.js:605:1
[SyncManager][317780.687] Saving user settings base_module.js:605:1
[SyncManager][317780.715] handling appterminated base_module.js:605:1
[SyncManager][317780.861] Setting value already saved,sync.collections.passwords.enabled base_module.js:605:1
[SyncManager][317780.864] Setting value already saved,sync.scheduler.wifionly base_module.js:605:1
[SyncManager][317780.866] Setting value already saved,sync.collections.history.enabled base_module.js:605:1
[SyncManager][317780.868] Setting value already saved,sync.scheduler.interval base_module.js:605:1
[SyncManager][317780.870] Setting value already saved,sync.collections.history.readonly base_module.js:605:1
[SyncManager][317780.872] Setting value already saved,sync.fxa.audience base_module.js:605:1
[SyncManager][317780.873] Setting value already saved,sync.collections.bookmarks.enabled base_module.js:605:1
[SyncManager][317780.876] Setting value already saved,sync.server.url base_module.js:605:1
[SyncManager][317780.877] Setting value already saved,sync.collections.passwords.readonly base_module.js:605:1
[SyncManager][317780.880] Setting value already saved,sync.collections.bookmarks.readonly base_module.js:605:1
[SyncManager][317780.882] Restoring default settings base_module.js:605:1
[SyncManager][317780.903] Restoring setting sync.collections.history.enabled, base_module.js:605:1
[SyncManager][317780.905] Restoring setting sync.collections.passwords.enabled, base_module.js:605:1
[SyncManager][317780.907] Restoring setting sync.collections.bookmarks.enabled, base_module.js:605:1
[SyncManager][317780.908] Restoring setting sync.collections.history.readonly, base_module.js:605:1
[SyncManager][317780.911] Restoring setting sync.collections.passwords.readonly, base_module.js:605:1
[SyncManager][317780.913] Restoring setting sync.collections.bookmarks.readonly, base_module.js:605:1
[SyncManager][317780.915] Restoring setting sync.server.url, base_module.js:605:1
[SyncManager][317780.916] Restoring setting sync.scheduler.interval, base_module.js:605:1
[SyncManager][317780.918] Restoring setting sync.scheduler.wifionly, base_module.js:605:1
[SyncManager][317780.920] Restoring setting sync.fxa.audience, base_module.js:605:1
[SyncManager][317780.922] handling onsyncdisabled base_module.js:605:1
[SyncManager][317780.923] onsyncdisabled observed base_module.js:605:1
[SyncManager][317780.925] Setting state,disabled base_module.js:605:1
Could not unregister sync task UnknownTaskError disabled sync_manager.js:538:1
[SyncManager][317780.982] Preference change,[object Object]
Flags: needinfo?(yzenevich)
Thank you Yura.

"Could not enable sync invalid account". This means that you didn't active the account properly.

(In reply to Yura Zenevich [:yzen] from comment #4)
> Hi Fernando, more details (with debugging enabled):
> 
> My steps:
> 
> * go to settings
> * go to sync
> * press get started
> * get a prompt to create Firefox account
> * go through the steps to create it
> * Observed: dialog that says i need to activate the account on other platform
> * activated account on desktop

How did you activate the account?

Note that this is not only verifying the FxA email, it also involves login in Sync and doing a first sync from desktop.
Flags: needinfo?(yzenevich)
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> Thank you Yura.
> 
> "Could not enable sync invalid account". This means that you didn't active
> the account properly.

Yeah this needs to be handled somehow because, the stuck state is confusing.

> 
> (In reply to Yura Zenevich [:yzen] from comment #4)
> > Hi Fernando, more details (with debugging enabled):
> > 
> > My steps:
> > 
> > * go to settings
> > * go to sync
> > * press get started
> > * get a prompt to create Firefox account
> > * go through the steps to create it
> > * Observed: dialog that says i need to activate the account on other platform
> > * activated account on desktop
> 
> How did you activate the account?
> 
> Note that this is not only verifying the FxA email, it also involves login
> in Sync and doing a first sync from desktop.

Ah ok, that's the case then, I only activated the link and didnt sync.
Flags: needinfo?(yzenevich)
(In reply to Yura Zenevich [:yzen] from comment #6)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> > Thank you Yura.
> > 
> > "Could not enable sync invalid account". This means that you didn't active
> > the account properly.
> 
> Yeah this needs to be handled somehow because, the stuck state is confusing.
> 

Yeah, that sucks. On of our priorities is to allow the creation of new Sync users from FxOS.
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #7)
> (In reply to Yura Zenevich [:yzen] from comment #6)
> > (In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> > > Thank you Yura.
> > > 
> > > "Could not enable sync invalid account". This means that you didn't active
> > > the account properly.
> > 
> > Yeah this needs to be handled somehow because, the stuck state is confusing.
> > 
> 
> Yeah, that sucks. On of our priorities is to allow the creation of new Sync
> users from FxOS.

s/On/One
Comment on attachment 8683760 [details] [review]
[gaia] ferjm:bug1220122.enabling.ui.feedback > mozilla-b2g:master

Works with active account. The code looks good too. Just one nit: could you use assert instead of expect for consistency across all of our unit tests since we have not been using it in Settings? Thanks!
Attachment #8683760 - Flags: review?(yzenevich) → review+
It works fine on my device at first try. But when I disable sync, it can't be enable again.. 
Even when I logout the Firefox Account, the getting start button in sync panel still shows 'signing in'


Though its unrelated to this patch, I spot some UX inconsistencies:
1. `Sign in` should not `blue`, just like firefox account panel
2. the document link should looks like links in device information panel, instead of buttons.


By the way, is it the right time to enable the panel by default in engineering build?
Flags: needinfo?(gasolin)
https://github.com/mozilla-b2g/gaia/commit/239f562474512140543130e6d284b3e872ffb3a8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Fred Lin [:gasolin] from comment #10)
> It works fine on my device at first try. But when I disable sync, it can't
> be enable again.. 
> Even when I logout the Firefox Account, the getting start button in sync
> panel still shows 'signing in'
> 

I can't reproduce this issue. Could you file a new bug and explain your STR with more detail, please? Also a log with SyncManager debug enabled would be highly appreciated.

> 
> Though its unrelated to this patch, I spot some UX inconsistencies:
> 1. `Sign in` should not `blue`, just like firefox account panel
> 2. the document link should looks like links in device information panel,
> instead of buttons.
> 

I filed bug 1224519 and will needinfo our UX team to get their feedback about the whole panel.

> 
> By the way, is it the right time to enable the panel by default in
> engineering build?

We could do that now, but we want to be able to create new users before enabling this feature to avoid the confusing UX Yura suffered while trying this patch.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: