Closed
Bug 1220197
Opened 9 years ago
Closed 6 years ago
Addon is not disabled if on the block list.
Categories
(Firefox OS Graveyard :: General, defect, P1)
Firefox OS Graveyard
General
Tracking
(feature-b2g:2.5+)
RESOLVED
WONTFIX
feature-b2g | 2.5+ |
People
(Reporter: nhirata, Unassigned)
References
Details
Attachments
(4 files)
1. flash the device a) For aries install : https://tools.taskcluster.net/task-inspector/#NVn1sh1lQme4wf4Rx3iXCQ/0 b) For flame install : https://tools.taskcluster.net/task-inspector/#CUUGoT7_Rs69FYNmyjdgbw/0 2. make sure you have settings -> developer -> Debugging via USB = ADB and DevTools 3. make sure Settings->Developer->Use Marketplace Reviewer Certs is checked (you'll also see this in Device Settings as dom.mozApps.use_reviewer_certs) With WebIDE: 4. In Device Settings, add the string value of dom.mozApps.signed_apps_installable_from to https://marketplace.firefox.com,https://marketplace.allizom.org,https://marketplace-dev.allizom.org 5. add string : extensions.blocklist.url with value https://blocklist.allizom.org/blocklist/3/%APP_ID%/%APP_VERSION%/%PRODUCT%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/%PING_COUNT%/%TOTAL_PING_COUNT%/%DAYS_SINCE_LAST_PING%/ 6. set pref("extensions.blocklist.interval", 30); 7. wait 30 seconds. 8 reboot the device 9 check addons -> in settings. Expected: the addon gets disabled Actual: the addon doesn't get disabled.
Reporter | ||
Comment 1•9 years ago
|
||
oope.s I forgot to mention in step 3.5 add "Unread Icons" from the marketplace in step 2.
Comment 2•9 years ago
|
||
I don't think this testing proves anything because waiting *just* 30 seconds is racy. Can you paste a logcat, to see the real blocklist url and content? Also, you don't need to reboot. You should see the addon being disabled in the settings app.
Comment 3•9 years ago
|
||
Shouldn't the Product be FxOS?
Reporter | ||
Comment 4•9 years ago
|
||
I waited over 5 minutes as well. The change never took place in settings/addons.
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(fabrice)
Comment 5•9 years ago
|
||
The blocklist retrieved is https://blocklist.allizom.org/blocklist/3/%7B3c2e2abc-06d4-11e1-ac3b-374f68613e61%7D/44.0a1/B2G/20151029180539/Android_arm-eabi-gcc3/en-US/nightly/Boot2Gecko%202.6.0.0-prerelease%20(SDK%2019)/default/default/invalid/invalid/0/ What is the id of the extension we expected to be blocked?
Flags: needinfo?(fabrice)
Comment 6•9 years ago
|
||
55733e2e9a834301b080e4d69a0f40ce
Comment 7•9 years ago
|
||
Thanks, so it's expected to be blocked by this snippet: <emItem blockID="i921" id="55733e2e9a834301b080e4d69a0f40ce"> <versionRange minVersion="0" maxVersion="100" severity="3"> <targetApplication id="{3c2e2abc-06d4-11e1-ac3b-374f68613e61}"> <versionRange minVersion="2.5" maxVersion="*"/> </targetApplication></versionRange> <prefs> </prefs> </emItem> This doesn't block because the minVersion="2.5" needs to be the gecko version. Or just don't add a versionRange here at all.
Reporter | ||
Comment 9•9 years ago
|
||
retest; still no change in settings. the webapps.json doesn't seem to have picked up the block. zip file contains requested logcat and /data/local/webapps/webapps.json
Flags: needinfo?(nhirata.bugzilla) → needinfo?(fabrice)
Comment 10•9 years ago
|
||
I can't do much since I can't set up anything to download from marketplace-dev. I would need at least the manifest & the package to reproduce with a local server.
Flags: needinfo?(fabrice)
Reporter | ||
Comment 11•9 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Reporter | ||
Comment 12•9 years ago
|
||
Blocklisting does not work end to end.
Reporter | ||
Comment 13•9 years ago
|
||
Reporter | ||
Comment 14•9 years ago
|
||
Fabrice, attached is the webbapps.json and the addon itself from the phone.
Flags: needinfo?(fabrice)
Updated•9 years ago
|
blocking-b2g: 2.5? → ---
feature-b2g: --- → 2.5+
Priority: -- → P1
Updated•9 years ago
|
Reporter | ||
Comment 15•9 years ago
|
||
Odd. I just checked on the Flame (which I left for testing the block) and the add on is disabled. On my Aries device, ( which was turned off due to not enough power) the addon is still enabled. Going to give it some time to see if it disables.
Reporter | ||
Comment 16•9 years ago
|
||
Comment 17•9 years ago
|
||
Can you re-test with a fresh aries build? There absolutely no device specific code there.
Updated•9 years ago
|
Flags: needinfo?(fabrice)
Reporter | ||
Comment 18•9 years ago
|
||
Blocked by not having Aries builds ( bug 1220739 ) : https://tools.taskcluster.net/index/artifacts/#gecko.v1.mozilla-central.latest.linux.aries-dogfood/gecko.v1.mozilla-central.latest.linux.aries-dogfood.debug currently indexes : https://tools.taskcluster.net/task-inspector/#Yih0tqraQjOz-Gwo-7dHoA/ which is 4 days old. I could make my own build, though I would rather test on an official build.
Updated•9 years ago
|
Component: Integration → General
Product: Marketplace → Firefox OS
Version: Avenir → unspecified
Updated•9 years ago
|
QA Whiteboard: [COM=Add-on]
Comment 19•6 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•