Add comment about "s in venkman properties file

VERIFIED FIXED in mozilla0.9.9

Status

Other Applications
Venkman JS Debugger
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Marek Wawoczny, Assigned: Robert Ginda)

Tracking

Trunk
mozilla0.9.9
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

17 years ago
There is no need to remove " char from begin and end of string in *.properties files. " char (escaped \" and unescaped ") is valid char which can be in any string in *.properties file.

This 2 lines are removing " from strings:
http://lxr.mozilla.org/mozilla/source/extensions/venkman/resources/content/venkman-msg.js#58
http://lxr.mozilla.org/mozilla/source/extensions/venkman/resources/content/venkman-msg.js#59

Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:0.9.8+) Gecko/20020126
(Assignee)

Comment 1

17 years ago
I remove those characters, only if they are at the first or last position in the
string, so that I can have strings with leading or trailing whitespace.

IE, foo = "          foo
is read in as 10 spaces, followed by foo
Status: UNCONFIRMED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

17 years ago
And what about stings like:
foo=this is something like "%S"

I know that U are removing them when they are on first and on last position...

I think that this is valid bug.

There is probably a better solution to have leading or trailing whitespace.
(Assignee)

Comment 3

17 years ago
So far the debugger has no need for strings in that format, though I agree it
may some day.  When and if getMsg ever has to act on a string with a leading or
trailing quote, an extra quote may be used, as in...
foo=this is something like "%S""

I'll add some comments explaining this convention in the .properties files, and
venkman-msg.js.  I think this is a resonable convention, seeing as how our
stringbundle code provides no way of expressing leading or trailing spaces AFAIK.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
(Assignee)

Comment 4

17 years ago
I'm not sure what happened there, the bug seems to have gone from INVALID to
UNCONFIRMED.  I meant to reopen as a request for a comment.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: No need to remove " char from strings in *.properties files - getMsg function → Add comment about "s in venkman properties file
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 5

17 years ago
checked in comments and examples
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
LOL.  vrfy fixed.

But it's spelled "sphincter" not "sphinctor".
Status: RESOLVED → VERIFIED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.