1220229 - Do not transform date/time patterns in pseudolocales

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: music-track-time-format.png

See screenshot

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Basically, 

https://github.com/mozilla-b2g/gaia/blob/11df0c1cc7d6e5dee40fb5e3ce7987525f2d08ac/shared/locales/date/date.en-US.properties#L230

datePickerOrder
timePickerOrder
durationPattern

should not be transformed in pseudolocales.

:stas - how did you do this for old time/date patterns?

Comment 2

[Staś Małolepszy :stas]

All we did was to exclude formatting tokens from the pseudo-l10n transformation in:

https://github.com/mozilla-b2g/gaia/blob/f7530dc80720bedacc797764fe774e11391d5234/shared/js/intl/l20n.js#L1725

I'm not sure how to best solve this.  Should we also specify datePickerOrder et al. with strftime-like tokens?

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1220229-escape-mozintl-strings-from-pseudo > mozilla-b2g:master

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8682015 [details] [review]
[gaia] zbraniecki:1220229-escape-mozintl-strings-from-pseudo > mozilla-b2g:master

Short term - escape the three strings from being pseudotranslated.

Long term - once I remove l10n_date (2.6), we will be able to just skip the whole date.properties.

Alternatively we could change entity name to have some prefix that indicates that it should not be pseudolocalized, but that would require localizers to retranslate it and seems like it wouldn't be the best long term pattern.

One more thing is that once we switch to l20n file format, we may have semantic comments that could mark entity for pseudolocales to skip.

Comment 5

[Staś Małolepszy :stas]

I'm a bit afraid of special-casing these three strings.  If there's a change to any of them, we'd introduce a regression.  Perhaps the chance of them changing is low, however.

Do we also need to make the same change in l10n.js?

Can't we change the string to datePickerOrder = %m%d%Y ?

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

> Do we also need to make the same change in l10n.js?

Yeah.

> Can't we change the string to datePickerOrder = %m%d%Y ?

I'm trying to keep our strings close to CLDR strings to enable us to one day automatically export CLDR data into l10n entities. The format they use is "mdY" 

Example: https://github.com/zbraniecki/Intl.js/blob/master/locale-data/json/pl.json#L25

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 8682015 [details] [review]
[gaia] zbraniecki:1220229-escape-mozintl-strings-from-pseudo > mozilla-b2g:master

This is an old bug; clearing the review request on me.  Please re-request if it's still valid.

Comment 8

[BMO Automation]

Firefox OS is not being worked on