Closed
Bug 1220238
Opened 9 years ago
Closed 9 years ago
mach hostutils manifest download is inefficient
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
3.40 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
To support host-utils downloads triggered by Android mach commands, mach downloads the tooltool manifest from hg. Frequently, that tooltool manifest file will already be present locally in the build top_srcdir -- we can copy it from there, eliminating a network access. I hope to re-use this technique for jimdb.
Assignee | ||
Comment 1•9 years ago
|
||
When downloading host-utils for Android, use the tooltool manifest in the top_srcdir, if available. This eliminates a network access and reduces reliance on hg.
Attachment #8681419 -
Flags: review?(jmaher)
Comment 2•9 years ago
|
||
Comment on attachment 8681419 [details] [diff] [review] use local manifest if available Review of attachment 8681419 [details] [diff] [review]: ----------------------------------------------------------------- looks good! nice find.
Attachment #8681419 -
Flags: review?(jmaher) → review+
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cb85c9ceaed3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 5•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/cb85c9ceaed3
status-b2g-v2.5:
--- → fixed
Comment 6•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•