1220310 - Make DefaultTracer into a generic GCPolicy

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: DefaultTracer_to_DefaultGCPolicy-v0.diff

I'd like to add "Sweepable" containers as the weak reflection of "Traceable"'s strong container. Rather than adding another DefaultFoo<T> for everything, i'd like to settle on a generic GCPolicy structure that tells us how any particular type interfaces with the GC. I'm not sure how this intersects with GCMethods yet -- there's probably enough overlap to merge, but I'd like to keep them separate for now.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8681523 [details] [diff] [review]
DefaultTracer_to_DefaultGCPolicy-v0.diff

Review of attachment 8681523 [details] [diff] [review]:
-----------------------------------------------------------------

This great! I took a brief stab at unifying Traceable with GCMethods, but quickly ran away and hid in a corner. This is a great direction to be moving in. Hopefully we can incrementally shift stuff over.

::: js/public/TraceableHashTable.h
@@ +161,4 @@
>  {};
>  
>  // A TraceableHashSet is a HashSet with an additional trace method that knows
> +// how to visit all set element. HashSets that contain GC pointers that must

I don't actually see a change in this line, but anyway: s/element/elements/

Comment 2

[Terrence Cole [:terrence]]

> >  // A TraceableHashSet is a HashSet with an additional trace method that knows
> > +// how to visit all set element. HashSets that contain GC pointers that must
> 
> I don't actually see a change in this line, but anyway: s/element/elements/

I changed the inter-sentence spacing to 1.

Comment 3

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7001fffefd3d

Comment 4

[Steve Fink [:sfink] [:s:]]

Looks happy to me: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28bd81e170a5

Comment 5

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf48dcfef48b

Comment 6

[Terrence Cole [:terrence]]

Oh, I didn't realize Steve had already re-tried this. :-P

Guess I'll just go cancel the try and push to m-i then.

Comment 7

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5c3654f4854fc4d80532105b7ef4729b991bd9
Bug 1220310 - Generalize GC container trace function dispatch as GCPolicy; r=sfink

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba5c3654f485