Closed Bug 1220341 Opened 10 years ago Closed 7 years ago

Clicking image preview after 'screenshot' command doesn't open downloads folder

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 affected, firefox42 affected, firefox43 affected, firefox44 affected, firefox45 affected, firefox-esr38 unaffected)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox41 --- affected
firefox42 --- affected
firefox43 --- affected
firefox44 --- affected
firefox45 --- affected
firefox-esr38 --- unaffected

People

(Reporter: arni2033, Unassigned)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [polish-backlog][difficulty=easy])

STR: (Win7_64, Nightly 45, 32bit, ID 20151029045227, new profile) 1. Open developer toolbar (Shift+F2) on this page, type "screenshot" w/o quotes, press enter 2. Click the image preview Result: Nothing [see URL for screenshot] Expectations: Downloads folder should open and the screenshot should be selected in that folder ---- It was regressed TWICE between 2015-04-28 and 2015-04-29. Well, this is definitely something new... 1) [e10s] STR above stopped working on _web_ pages in e10s mode. After the regression it still worked fine on about:newtab in e10s mode and on all pages in non-e10s Bug 1151767 > pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=96862be5fb53720df2556d2ad01fbabbea2be3e0&tochange=72e664840cf4e89e187ca145ce54f52d194dc5f4 2) It was completely broken even in non-e10s and started to throw errors in console after Step 2 Bug 1018619 > pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a3d3da50bc0fc87d623923fc493bdaaa41fce254&tochange=867a54667d28de42a10527ebb1c4484744313cbd
https://hg.mozilla.org/mozilla-central/rev/ab89cbfcd3e6 The "filename = OS.Path.join(preferredDir, filename);" disappear.
No longer blocks: 1151767
Flags: needinfo?(jryans)
When we changed to using `saveURL` to get visual feedback on save, we also lost the ability to know for sure what directory the file went to. The file saving logic behind `saveURL` is quite complex. A simpler workaround may be to open the Downloads window on click, which can then be used to reveal the file.
Flags: needinfo?(jryans)
Whiteboard: [polish-backlog][difficulty=easy]
Has STR: --- → yes
Product: Firefox → DevTools
Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.