1220407 - Fix build on non-linux unix systems

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Landry Breuil (:gaston)]

Right now the build fails on OpenBSD:

toolkit/components/perfmonitoring/nsPerformanceStats.cpp:871:17: error: variable has incomplete type 'struct rusage'
 7:42.46   struct rusage rusage;

We need to include sys/resource.h not only in the XP_LINUX case here https://dxr.mozilla.org/mozilla-central/source/toolkit/components/perfmonitoring/nsPerformanceStats.cpp?from=nsPerformanceStats.cpp#46 

currently testing XP_UNIX instead, might want to use #elif XP_UNIX to not over-include stuff on macos...

Comment 1

[David Teller [:Yoric] - still alive but not very active]

I can review a patch, if you have one.

Comment 2

[Landry Breuil (:gaston)]

Attachment: Use XP_UNIX instead of XP_LINUX

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8681655 [details] [diff] [review]
Use XP_UNIX instead of XP_LINUX

Review of attachment 8681655 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/83ee1cb04baa

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/83ee1cb04baa

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/83ee1cb04baa