Closed
Bug 1220407
Opened 9 years ago
Closed 9 years ago
Fix build on non-linux unix systems
Categories
(Toolkit :: Performance Monitoring, defect)
Toolkit
Performance Monitoring
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: gaston, Assigned: gaston)
Details
Attachments
(1 file)
1003 bytes,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Right now the build fails on OpenBSD: toolkit/components/perfmonitoring/nsPerformanceStats.cpp:871:17: error: variable has incomplete type 'struct rusage' 7:42.46 struct rusage rusage; We need to include sys/resource.h not only in the XP_LINUX case here https://dxr.mozilla.org/mozilla-central/source/toolkit/components/perfmonitoring/nsPerformanceStats.cpp?from=nsPerformanceStats.cpp#46 currently testing XP_UNIX instead, might want to use #elif XP_UNIX to not over-include stuff on macos...
I can review a patch, if you have one.
Assignee | ||
Comment 2•9 years ago
|
||
Assignee: nobody → landry
Attachment #8681655 -
Flags: review?(dteller)
Comment on attachment 8681655 [details] [diff] [review] Use XP_UNIX instead of XP_LINUX Review of attachment 8681655 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks.
Attachment #8681655 -
Flags: review?(dteller) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/83ee1cb04baa
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 6•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/83ee1cb04baa
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•