Make --disable-compile-environment on mobile/android work without the Android NDK

RESOLVED FIXED in Firefox 45

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

(Depends on: 1 bug)

unspecified
mozilla45
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1159371 and friends made --disable-compile-environment work for --enable-application=mobile/android.  Unfortunately, we still configure (and use parts of?) the Android NDK toolchain.

This ticket tracks making mobile/android builds work we have no compile environment and no --with-android-ndk configured in the mozconfig.
(Assignee)

Comment 1

3 years ago
Created attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium
Attachment #8682261 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

3 years ago
I just tested an artifact build with --target=i386-linux-android and it produced an APK that looks good, but I don't have an x86 device to test right now.  I tested --target=arm-linux-androideabi earlier.
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

https://reviewboard.mozilla.org/r/24023/#review21457

::: configure.in:1259
(Diff revision 1)
> +    MOZ_ARCH=armv7-a

Seems to me this should be in a else alternative to MOZ_ARCH_OPTS, which then allows to not duplicate MOZ_ANDROID_CPU_ARCH here.
Attachment #8682261 - Flags: review?(mh+mozilla)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium
Attachment #8682261 - Flags: review?(mh+mozilla)
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

https://reviewboard.mozilla.org/r/24023/#review21463
Attachment #8682261 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/b423610b2e44ba5b63458608d4f78c979d970e77
Bug 1220476 - Make --disable-compile-environment work for Android builds without an Android NDK. r=glandium
(Assignee)

Updated

3 years ago
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Blocks: 1221200

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b423610b2e44
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b423610b2e44
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
(Assignee)

Updated

3 years ago
Depends on: 1222544
Depends on: 1224286
Depends on: 1228256

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.