1220500 - local robocop test fails: |LOG: MainThread ERROR org.mozilla.$(MOZ_APP_NAME) is not installed on this device|

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Mark Capella [:capella]]

I haven't run robocop locally recently, but currently on running: |./mach robocop tetSelectionCarets|, I'm getting error message:
   0:00.89 LOG: MainThread ERROR org.mozilla.$(MOZ_APP_NAME) is not installed on this device

Simply removing the check here gets me past the error ...
   http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runrobocop.py?rev=e65ea9918140&mark=526-531#515

fwiw: |options.app| in that block resolves to |org.mozilla.$(MOZ_APP_NAME)|

Comment 1

[Geoff Brown [:gbrown]]

|./mach robocop testSelectionCarets| still works fine for me.

options.app should be ANDROID_PACKAGE_NAME, usually org.mozilla.fennec_gbrown for me. I wonder if this is the difference between something like

http://hg.mozilla.org/mozilla-central/annotate/96377bdbcdf3/mobile/android/branding/unofficial/configure.sh#l5

and

http://hg.mozilla.org/mozilla-central/annotate/96377bdbcdf3//configure.in#l329

Comment 2

[Nick Alexander :nalexander [he/him]]

I don't see this.  capella, is it possible you are running this in an unusual shell; or that you are running this against a desktop build?  I can't see where options.app comes from *and doesn't get shell expanded*.

Your mozconfig, objdir name, and $OBJDIR/config.status would help here.

Comment 3

[Mark Capella [:capella]]

Clearing ?ni ... I'm not a build / make / configure / autoconf (etc) person, but I'll dig a little further.

All I see for now is that my ANDROID_PACKAGE_NAME is set from MOZ_APP_NAME here:
   http://mxr.mozilla.org/mozilla-central/source/configure.in?rev=f7a19fa7fad2&mark=329#325

But my MOZ_APP_NAME isn't itself set from MOZ_APP_BASENAME |Fennec| until later, here:
   http://mxr.mozilla.org/mozilla-central/source/configure.in?rev=f7a19fa7fad2&mark=8734#8702

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1220500 - Set ANDROID_PACKAGE_NAME correctly from MOZ_APP_NAME. r?glandium

Review commit: https://reviewboard.mozilla.org/r/28835/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28835/

Comment 5

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa99e9a072ac

Comment 6

[Mark Capella [:capella]]

awesomeness! Thanks so much for remembering this :-D

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8700894 [details]
MozReview Request: Bug 1220500 - Set ANDROID_PACKAGE_NAME correctly from MOZ_APP_NAME. r?glandium

https://reviewboard.mozilla.org/r/28835/#review25625

Comment 8

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/91c2a2502721dfcaf032cbd0c419d3e789f334f6
Bug 1220500 - Set ANDROID_PACKAGE_NAME correctly from MOZ_APP_NAME. r=glandium

Comment 9

[Nick Alexander :nalexander [he/him]]

capella: can you confirm this helps?

Comment 10

[Mark Capella [:capella]]

I sure can! I special installed prior to my comment #6 and it's push to fx-team

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91c2a2502721