IonMonkey: MIPS64: Fix workaround for Loongson3 in Assembler::bind

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

unspecified
mozilla45
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The MacroAssembler::branchWithCode has reserved space (7 instructions) for open conditional jump. At bind stage, the distance bewteen branch and target might be within bounds. If true, skip the trailing nops would better than sequential execute these. But on Loongson3 platforms, this is not a good idea. From the actual test results, don't skip these nops can imporve the performance.
(Assignee)

Comment 1

3 years ago
Created attachment 8681737 [details] [diff] [review]
0001-IonMonkey-MIPS64-Fix-workaround-for-Loongson3-in-Ass.patch
Attachment #8681737 - Flags: review?(hwjeastd07)

Updated

3 years ago
Attachment #8681737 - Flags: review?(hwjeastd07) → review+

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc5663e47d67
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.