Closed
Bug 1220505
Opened 9 years ago
Closed 9 years ago
IonMonkey: MIPS64: Fix workaround for Loongson3 in Assembler::bind
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file)
2.08 KB,
patch
|
hwjeastd07
:
review+
|
Details | Diff | Splinter Review |
The MacroAssembler::branchWithCode has reserved space (7 instructions) for open conditional jump. At bind stage, the distance bewteen branch and target might be within bounds. If true, skip the trailing nops would better than sequential execute these. But on Loongson3 platforms, this is not a good idea. From the actual test results, don't skip these nops can imporve the performance.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8681737 -
Flags: review?(hwjeastd07)
Updated•9 years ago
|
Attachment #8681737 -
Flags: review?(hwjeastd07) → review+
Comment 3•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc5663e47d67
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•