Closed
Bug 1220516
Opened 10 years ago
Closed 10 years ago
make CSSStyleSheet::GetOriginalURI non-virtual
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
There's no need for CSSStyleSheet::GetOriginalURI to be virtual.
|
Assignee | |
Comment 1•10 years ago
|
||
Especially since CSSStyleSheet is final.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8681759 [details] [diff] [review]
patch
r=me on the assumption that no one uses this class outside libxul.
Attachment #8681759 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2)
> r=me on the assumption that no one uses this class outside libxul.
Is there any due diligence I can do about that? (I searched in comm-central and didn't find any uses of it.)
Flags: needinfo?(bzbarsky)
|
|
||
Comment 4•10 years ago
|
||
> Is there any due diligence I can do about that?
Not really, sadly. I think this should be fine in this case.
Flags: needinfo?(bzbarsky)
|
|
||
Comment 6•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•