1220525 - Add -Zc:inline for MSVC build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

MSVC2013 update 2+ has new compiler option "-Zc:inline" to reduce COMDAT size.

The following result is when I add this option to compiler option to build xul.dll on my build environment (MSVS2015 RTM x86 opt build).

Normal (time mozmake -C $(OBJDIR)/toolkit/library)

real    1m31.687s
user    0m0.000s
sys     0m0.015s

With -Zc:inline

real    1m8.512s
user    0m0.000s
sys     0m0.015s

Comment 1

[Makoto Kato [:m_kato]]

Windows x64 build using VS2015 Update 1
With    -Zc:inline ... 39m44s
Without -Zc:inlune ... 43m52s

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1220525 - Add -Zc:inline for MSVC build.

-Zc:inliune introduces VS2013 update 2 to reduce build time.

https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/

On my workstation (i7-3770, 4 cores 8 threads), the build time by clean build (--enable-optimize and --disable-debug) is the following.

With    -Zc:inline ... 39m44s
Without -Zc:inlune ... 43m52s

So we should use this option to improve build time.

Review commit: https://reviewboard.mozilla.org/r/58926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58926/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8761909 [details]
Bug 1220525 - Add -Zc:inline for MSVC build.

https://reviewboard.mozilla.org/r/58926/#review55828

The documentation says this doesn't do anything with optimization is disabled or when -GL is passed. Should we bother trying not to set it in those situations, or is it harmless?

Also I didn't know about `/LTCG:incremental`, we should try that out for our PGO builds!

Comment 4

[(not currently active) Ted Mielczarek]

Filed bug 1279457 on LTCG:incremental.

Comment 5

[Makoto Kato [:m_kato]]

https://reviewboard.mozilla.org/r/58926/#review55828

If using -Od or -GL with -Zc:inline, this Zc:inline is ignore.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f6e4108360d
Add -Zc:inline for MSVC build. r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f6e4108360d