1220527 - Link doesn't work on upgrade notification if clicked too early

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tanvi Vyas[:tanvi]]

If users click on the Upgraded Notifications message too early (before the browser window opens), the click is lost.  The message disappears on click, but the browser never opens a tab to the push learn more link.

Comment 1

[Lina Butler [:lina]]

Looking at how to implement this: should we use `Services.ww.openWindow` to open a new browser window if we don't have a most-recent window?

Comment 2

[Matthew N. [:MattN]]

I think we can just move the code to run at first window restore (see _onFirstWindowLoaded).

I thought there was a helper to fallback to opening a new window but I can't find it.

Comment 3

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

https://reviewboard.mozilla.org/r/23985/#review21423

Thanks!

Comment 5

[Lina Butler [:lina]]

https://hg.mozilla.org/integration/fx-team/rev/436f6fab5d4e773138e128c7163238620aa40730
Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Approval Request Comment
[Feature/regressing bug #]: bug 1216271
[User impact if declined]: If startup is slow, clicking on the notification won't do anything despite the text saying "Click to learn more".
[Describe test coverage new/current, TreeHerder]: No automated test change since it's for a one-time notification. There is a test for the initial notification behaviour.
[Risks and why]:  Low risk one-time migration change
[String/UUID change made/needed]: None

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/436f6fab5d4e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/436f6fab5d4e

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

This seems to be a regression we should fix, let's uplift to Aurora44.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce9fb5861455

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ce9fb5861455