Link doesn't work on upgrade notification if clicked too early

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tanvi, Assigned: kitcambridge)

Tracking

(Depends on: 1 bug)

44 Branch
Firefox 45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 unaffected, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
If users click on the Upgraded Notifications message too early (before the browser window opens), the click is lost.  The message disappears on click, but the browser never opens a tab to the push learn more link.
Looking at how to implement this: should we use `Services.ww.openWindow` to open a new browser window if we don't have a most-recent window?
I think we can just move the code to run at first window restore (see _onFirstWindowLoaded).

I thought there was a helper to fallback to opening a new window but I can't find it.
Created attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN
Attachment #8682203 - Flags: review?(MattN+bmo)
Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

https://reviewboard.mozilla.org/r/23985/#review21423

Thanks!
Attachment #8682203 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/integration/fx-team/rev/436f6fab5d4e773138e128c7163238620aa40730
Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
status-firefox43: --- → unaffected
status-firefox44: --- → affected
status-firefox45: --- → affected
Component: DOM: Push Notifications → General
Product: Core → Firefox
Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

Approval Request Comment
[Feature/regressing bug #]: bug 1216271
[User impact if declined]: If startup is slow, clicking on the notification won't do anything despite the text saying "Click to learn more".
[Describe test coverage new/current, TreeHerder]: No automated test change since it's for a one-time notification. There is a test for the initial notification behaviour.
[Risks and why]:  Low risk one-time migration change
[String/UUID change made/needed]: None
Attachment #8682203 - Flags: approval-mozilla-aurora?

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/436f6fab5d4e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/436f6fab5d4e
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: --- → ---
Comment on attachment 8682203 [details]
MozReview Request: Bug 1220527 - Wait for the first window before showing the upgraded notifications alert. r=MattN

This seems to be a regression we should fix, let's uplift to Aurora44.
Attachment #8682203 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ce9fb5861455
status-firefox44: affected → fixed

Comment 12

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ce9fb5861455
status-b2g-v2.5: --- → fixed
Depends on: 1221408
You need to log in before you can comment on or make changes to this bug.