1220531 - Change push Learn More link from mozilla.org to support.mozilla.org

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tanvi Vyas[:tanvi]]

In Bug 1220322 we created a migration URI that pointed to part of a sumo article.  This bug is to move the Learn More link for notifications off https://www.mozilla.org/en-US/firefox/push/ of and onto https://support.mozilla.org/en-US/kb/push-notifications-firefox

+++ This bug was initially created as a clone of Bug #1220322 +++

As soon as we have https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/push working with some the Push Notification text (bug 1220250) we will need to update the urls in our codebase to point here instead of https://www.mozilla.org/en-US/firefox/push/.

For the one time notification prompt on upgrade to let the user know about notification changes, we can link directly to a part of the page using something like:
https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/push#w_[What's-New]

Code to change is here:
http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#998

Comment 1

[Tanvi Vyas[:tanvi]]

Attachment: use-sumo-for-notification-learn-more.patch

Comment 2

[Tanvi Vyas[:tanvi]]

Attachment: Bug1220531-11-01-15.patch

Comment 3

[Tanvi Vyas[:tanvi]]

Comment on attachment 8681786 [details] [diff] [review]
Bug1220531-11-01-15.patch

Bill said to go ahead and make this change, so r? to MattN.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8681786 [details] [diff] [review]
Bug1220531-11-01-15.patch

Review of attachment 8681786 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Please make sure the content is ready before landing this. I agree this should have been on SUMO from the beginning since it's user-facing docs and we have a publishing pipeline on SUMO for this, no need to bug webdev.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8681786 [details] [diff] [review]
Bug1220531-11-01-15.patch

Review of attachment 8681786 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, can you remove these 2 prefs and use the standard method of:

Services.urlFormatter.formatURLPref("app.support.baseURL") + "push"
and
Services.urlFormatter.formatURLPref("app.support.baseURL") + "push#w_upgraded-notifications"

in the code?

Comment 6

[Tanvi Vyas[:tanvi]]

The content is updated: https://support.mozilla.org/en-US/kb/push-notifications-firefox

(In reply to Matthew N. [:MattN] from comment #5)
> Comment on attachment 8681786 [details] [diff] [review]
> Bug1220531-11-01-15.patch
> 
> Review of attachment 8681786 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Actually, can you remove these 2 prefs and use the standard method of:
> 
> Services.urlFormatter.formatURLPref("app.support.baseURL") + "push"
> and
> Services.urlFormatter.formatURLPref("app.support.baseURL") +
> "push#w_upgraded-notifications"
> 
> in the code?

Just to confirm, you want to remove the about:config prefs completely?

Although we should land and uplift this, the content on both the sumo page and the www.mozilla.org page should be updated and almost identical by tomorrow morning.  Unassigning myself from this bug and I'll let someone from the push team pick this up, as I have to get back to my day job.

Comment 7

[Matthew N. [:MattN]]

(In reply to Tanvi Vyas [:tanvi] from comment #6)
> Just to confirm, you want to remove the about:config prefs completely?

Yes from this file and prefs_general.js, this may require updating the tests and adding this app.support.baseURL pref to prefs_general.js plus a try push.

> Although we should land and uplift this, the content on both the sumo page
> and the www.mozilla.org page should be updated and almost identical by
> tomorrow morning. 

Thanks for handling the transition of content.

Comment 8

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1220531 - Link to the Push notifications article on SUMO. r=MattN

Bug 1220531 - Link to the Push notifications article on SUMO. r=MattN

Comment 9

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73f07190af6d

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 8685495 [details]
MozReview Request: Bug 1220531 - Link to the Push notifications article on SUMO. r=MattN

https://reviewboard.mozilla.org/r/24801/#review22321

Thanks!

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/73f07190af6d

Comment 12

[Lina Butler [:lina]]

Comment on attachment 8685495 [details]
MozReview Request: Bug 1220531 - Link to the Push notifications article on SUMO. r=MattN

Approval Request Comment
[Feature/regressing bug #]: "Notifications upgraded" alert (bug 1216271).
[User impact if declined]: Users who click the alert to learn more about Push notifications will be taken to an outdated info page.
[Describe test coverage new/current, TreeHerder]: The patch includes an updated browser chrome test pointing to the new URL.
[Risks and why]: We want to direct curious users to SUMO to learn more about this feature. Low risk.
[String/UUID change made/needed]: None.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8685495 [details]
MozReview Request: Bug 1220531 - Link to the Push notifications article on SUMO. r=MattN

Given that push notifications is planned for FF44, it makes sense to link to the correct SUMO article. Let's uplift to Aurora44.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd19fd9498a2

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/dd19fd9498a2

Comment 16

[Edwin Wong [:edwong]]

on windows nightly I got a migration notification and when i clicked on it i got this URL:

https://support.mozilla.org/1/firefox/45.0a1/WINNT/en-US/push#w_upgraded-notifications

which returned a 404.

-e

Comment 17

[Matthew N. [:MattN]]

After a bug has been uplifted or even landed on mozilla-central it's preferred to file a new bug so it can properly be tracked with the proper version. Please file a new bug blocking this if you still see the problem but that link works fine for me now.

Comment 18

[Edwin Wong [:edwong]]

oh - yeah URL works now - must have been the network outage.