1220534 - Intermittent failure browser_animation_playerState.js | The 2nd animation's playState is correct - Got finished, expected running | TypeError: player is undefined

Status: RESOLVED INCOMPLETE

(DevTools :: Inspector, defect, P3)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

We're seeing failure like the following:

  devtools/server/tests/browser/browser_animation_playerState.js | The 2nd animation's playState is correct - Got finished, expected running
  (https://treeherder.mozilla.org/logviewer.html#?job_id=16643391&repo=mozilla-inbound)
  (https://treeherder.mozilla.org/logviewer.html#?job_id=16640972&repo=mozilla-inbound)

  devtools/server/tests/browser/browser_animation_playerState.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/server/tests/browser/browser_animation_playerState.js:93 - TypeError: player is undefined
  (https://treeherder.mozilla.org/logviewer.html#?job_id=16645657&repo=mozilla-inbound)

It appears that the problem is that browser_animation_playerState.js is assuming an animation is running but it has already finished. Looking at the animation in animation.html, the animation is only 2s long.

Normally, if we're going to assume an animation is still running, we make it at least 100s long so that even if the test machine is really bogged down, it still passes. We used to have a lot of intermittent failures with animation tests before we started doing this.

I'm not sure why this has suddenly started appearing, however. The first instance I can see coincided with bug 1216846 but I don't know why that would trigger it. I think there has been a lot of flux in animation inspector code so perhaps something else is causing tests to run more slowly and make us more likely to hit this?

If we can't fix this soon, we might need to disable browser_animation_playerState.js.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Patrick, can we just extend the duration of animations in animations.html or would that break other things? Or make other tests take longer? (e.g. are there tests that actually wait for those animations to finish?)

Comment 2

[Patrick Brosset <:pbro>]

I had a quick look at the tests in devtools/server/tests/browser/browser_animation* and didn't see any that waited for the animations on <div class="multiple-animations"></div> to finish, so I think it's safe to change them to last 100s or so.

Comment 3

[Intermittent Failures Robot]

20 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 11
* try: 6
* fx-team: 2
* b2g-inbound: 1

Platform breakdown:
* linux64: 20

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1220534&startday=2015-11-02&endday=2015-11-08&tree=all

Comment 4

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* fx-team: 2

Platform breakdown:
* linux32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1220534&startday=2015-12-28&endday=2016-01-03&tree=all

Comment 5

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOES).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.