Closed Bug 1220556 Opened 4 years ago Closed 4 years ago

No feedback after performing Copy link

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- verified
fennec - ---

People

(Reporter: ioana.chiorean, Assigned: alex_johnson, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

All phones/tablets - all Android versions

Steps:
1. Open a website that has links on the webpage. 
2. Long tap on one of the links
3. Choose "Copy link"

Expected Result:
- for all other options present in Context menu for links appears some feedback/toast notification after choosing the action ( New tab opened, Bookmark added, etc). 
- the user would expect a feedback for this too. 

Actual Result: 
- no feedback is displayed after choosing the action of "Copy link"
Is this a regression? I thought we used to show a toast. Or maybe that's just for the text selection action bar.
tracking-fennec: --- → ?
A toast could be a nice improvement here.
Mentor: margaret.leibovic
tracking-fennec: ? → -
Whiteboard: [lang=js]
That could be a good start.. and eventually a snackbar!
Bug 1220556 - No feedback after performing Copy link. r?"Margaret Leibovic"
Attachment #8683874 - Flags: review?(margaret.leibovic)
Comment on attachment 8683874 [details]
MozReview Request: Bug 1220556 - No feedback after performing Copy link. r?"Margaret Leibovic"

https://reviewboard.mozilla.org/r/24459/#review21957

This looks good to me. A quick search of where we copy text to the clipboard from web content reveals that we show a toast everywhere else:
http://mxr.mozilla.org/mozilla-central/search?string=copystring%28&find=%2Fmobile%2Fandroid%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Attachment #8683874 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → mrjohnsonalex
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d5b4d4fc3bed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Verified as fixed on latest nightly build (45.0a1- 11-10-2015) on Xiaomi Mi i4, Sony Xperia Z2 (both with Android 5.0.2) and on Nexus 9 with Android 6.0
Duplicate of this bug: 836677
You need to log in before you can comment on or make changes to this bug.