1220556 - No feedback after performing Copy link

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

All phones/tablets - all Android versions

Steps:
1. Open a website that has links on the webpage. 
2. Long tap on one of the links
3. Choose "Copy link"

Expected Result:
- for all other options present in Context menu for links appears some feedback/toast notification after choosing the action ( New tab opened, Bookmark added, etc). 
- the user would expect a feedback for this too. 

Actual Result: 
- no feedback is displayed after choosing the action of "Copy link"

Comment 1

[:Margaret Leibovic]

Is this a regression? I thought we used to show a toast. Or maybe that's just for the text selection action bar.

Comment 2

[:Margaret Leibovic]

A toast could be a nice improvement here.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

That could be a good start.. and eventually a snackbar!

Comment 4

[Alex Johnson (:alex_johnson)]

Attachment: MozReview Request: Bug 1220556 - No feedback after performing Copy link. r?"Margaret Leibovic"

Bug 1220556 - No feedback after performing Copy link. r?"Margaret Leibovic"

Comment 5

[:Margaret Leibovic]

Comment on attachment 8683874 [details]
MozReview Request: Bug 1220556 - No feedback after performing Copy link. r?"Margaret Leibovic"

https://reviewboard.mozilla.org/r/24459/#review21957

This looks good to me. A quick search of where we copy text to the clipboard from web content reveals that we show a toast everywhere else:
http://mxr.mozilla.org/mozilla-central/search?string=copystring%28&find=%2Fmobile%2Fandroid%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d5b4d4fc3bed

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d5b4d4fc3bed

Comment 8

[u549602]

Verified as fixed on latest nightly build (45.0a1- 11-10-2015) on Xiaomi Mi i4, Sony Xperia Z2 (both with Android 5.0.2) and on Nexus 9 with Android 6.0