Closed Bug 1220567 Opened 9 years ago Closed 9 years ago

[TV] System Banner(Toast)

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: tchen, Assigned: rexboy)

Details

(Whiteboard: [ft:conndevices][partner-blocker])

Attachments

(4 files)

SSTV_Building_blocks_Specifcation_v07.pdf
2.15 MB, application/pdf
Details
[TV]Building Blocks_0.2.pdf
5.18 MB, application/pdf
Details
Screenshot
196.58 KB, image/png
tchen
: feedback+
Details
[gaia] rexboy7:system-banner-style > mozilla-b2g:master
46 bytes, text/x-github-pull-request
jj.evelyn
: review+
jocheng
: approval-gaia-v2.5+
Details | Review 
We need to implement the banner(toast).
No longer depends on: 1220530, 1218665
visual spec (P18. banner)
UX spec (P5. banner)
Hi Evelyn, can you find someone helping this? Thanks!
Flags: needinfo?(ehung)
Rex, could you have bandwidth for this?
Flags: needinfo?(ehung) → needinfo?(rexboy)
Assignee: nobody → rexboy
Flags: needinfo?(rexboy)
Attached image Screenshot — 
Tori may you confirm the appearance?
Attachment #8683629 - Flags: feedback?(tchen)
This visual applies to features that calls system banner.
(For now: app install, crash report, and update manager.)
We can discuss if we need new use cases.
Attachment #8683629 - Flags: feedback?(tchen) → feedback+
Comment on attachment 8683631 [details] [review]
[gaia] rexboy7:system-banner-style > mozilla-b2g:master

Sorry I forget to push this :(
Evelyn are you available for reviewing this visual change?
Attachment #8683631 - Flags: review?(ehung)
Comment on attachment 8683631 [details] [review]
[gaia] rexboy7:system-banner-style > mozilla-b2g:master

LGTM. Thanks.
Attachment #8683631 - Flags: review?(ehung) → review+
Thank you!
master:
https://github.com/mozilla-b2g/gaia/commit/71b40e4428cb5f160fdcc0bbfae014335a26ff76
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Comment on attachment 8683631 [details] [review]
[gaia] rexboy7:system-banner-style > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Style of system banner hasn't been adjusted for TV before
[User impact] if declined: Strange system banner visual style
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): small, just CSS changes.
[String changes made]:no
Attachment #8683631 - Flags: approval-gaia-v2.5?
Whiteboard: [partner-cherry-pick]
Whiteboard: [partner-cherry-pick] → [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-blocker]
blocking-b2g: 2.5? → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Comment on attachment 8683631 [details] [review]
[gaia] rexboy7:system-banner-style > mozilla-b2g:master

Approve for TV System Banner
Attachment #8683631 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: