Closed Bug 1220568 Opened 9 years ago Closed 9 years ago

[RTL][Calendar]Icons in the toolbar are not resequenced from right to left.

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.5 affected, b2g-master verified)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v2.5 --- affected
b2g-master --- verified

People

(Reporter: qiutian, Assigned: autra)

References

Details

(Whiteboard: [2.5-rtl-test-run])

Attachments

(3 files)

cla_icon.png
234.50 KB, image/png
Details
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
kgrandon
: feedback+
Details | Review
Verified_Master_toolbar.png
128.93 KB, image/png
Details
Attached image cla_icon.png — 
[1.Description]:
[RTL][Calendar][Aries kk_v2.6][Flame kk_v2.5&v2.6]When device language is Arabic, launch Calendar and sign in any email, tap menu and observe the display. Icons in the toolbar are not resequenced from right to left, the update icon is on the right and the gear icon is on the left.
See attachment: cla_icon.png

[2.Testing Steps]: 
1. Set your phone language to Arabic. 
2. Launch Calendar. 
3. Sign in any email. 
4. Tap menu and observe the display. 

[3.Expected Result]: 
In step 4, Icons in the toolbar will be resequenced from right to left, the update icon will be on the left and the gear icon will be on the right.

[4.Actual Result]: 
In step 4, Icons in the toolbar are not resequenced from right to left, the update icon is on the right and the gear icon is on the left.

[5.Reproduction build]: 
Device: AriesKK_2.6[Affected]
Build ID               20151101012023
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/96377bdbcdf3e444a22aeaa677da696243b00d98
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151101.004008
Firmware Date          Sun Nov  1 00:40:17 UTC 2015
Bootloader             s1

Device: FlameKK_v2.6[Affected]
Build ID               20151101150206
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/96377bdbcdf3e444a22aeaa677da696243b00d98
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151101.183234
Firmware Date          Sun Nov  1 18:32:48 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame_v2.5[Affected]
Build ID               20151101004501
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/36d8fc192b45d26eb4d32bbeae19f79cb2aebb65
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151101.031103
Firmware Date          Sun Nov  1 03:11:16 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15911
QA Whiteboard: rtl-impact
status-b2g-v2.5: --- → affected
status-b2g-master: --- → affected
Priority: -- → P3
Assignee: nobody → augustin.trancart
Status: NEW → ASSIGNED
Comment on attachment 8684955 [details] [review]
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master

Hi Kevin,

New specs says we mirror tabs :-)

Please r?
Attachment #8684955 - Flags: review?(kevingrandon)
Comment on attachment 8684955 [details] [review]
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master

This looks fine to me, but I guess Gareth should take a look at this one. Thanks!
Attachment #8684955 - Flags: review?(kevingrandon)
Attachment #8684955 - Flags: review?(gaye)
Attachment #8684955 - Flags: feedback+
Hey Kevin,

Gareth seems not to be around. Do you know who else I can ping on that?
Flags: needinfo?(kevin+bugzilla)
I'm not sure, perhaps we can ask Dylan?

Dylan - could you help us to locate a suitable reviewer? Thanks!
Flags: needinfo?(kevin+bugzilla) → needinfo?(doliver)
Gareth has been out for the holidays but I believe he will be back tomorrow so I'll ping him about this one.
Flags: needinfo?(doliver)
Comment on attachment 8684955 [details] [review]
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master

LGTM!
Attachment #8684955 - Flags: review?(gaye) → review+
https://github.com/mozilla-b2g/gaia/commit/fc73dae8b31e3788bce00dd9890bcfe78d17aeb0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Hi Autumn,

    Could you please help to verify this bug on master?

Thank you.
Flags: needinfo?(qiutian)
Comment on attachment 8684955 [details] [review]
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: not perfect rtl experience
[Testing completed]: on flame master
[Risk to taking this patch] (and alternatives if risky): very low risk.
[String changes made]: none
Attachment #8684955 - Flags: approval-gaia-v2.5?
This bug has been verified as "pass" on the latest build of Aries KK Master and Flame KK Master 512mb by the STR in comment 0.

Actual results: Icons in the toolbar are re-sequenced from right to left, the update icon is on the left and the gear icon is on the right.
See attachment: Verified_Master_toolbar.png
Reproduce rate: 0/10

Device: Aries KK Master(Pass)
Build ID               20151206002630
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151205.234548
Firmware Date          Sat Dec  5 23:45:56 UTC 2015
Bootloader             s1

Device: Flame KK Master 512mb(Pass)
Build ID               20151206030530
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151206.064055
Firmware Date          Sun Dec  6 06:41:08 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
Flags: needinfo?(qiutian)
QA Whiteboard: rtl-impact → rtl-impact[MGSEI-Triage+]
Comment on attachment 8684955 [details] [review]
[gaia] Phoxygen:bug1220568-calendar_drawer_tabs > mozilla-b2g:master

Limiting 2.5 only to TV patches. Foxfooders getting updates from master/b2g-ota branch. Removing the uplift nomination.

Verified on Master, will be available to foxfooders in next update. 

Thank you
Attachment #8684955 - Flags: approval-gaia-v2.5?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: