1220589 - [TV] FTE for Pin-to-home context menu button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This bug should implement FTE for context menu button.
Refer to UX:
https://drive.google.com/a/mozilla.com/folderview?id=0B5RN80W56Ga9fjlncXJuZW5YbW0zX2tDX0sta3FsMXU3cmRYM0hTOEJXZFZ2ck5wSW1PZlU&usp=sharing&tid=0B5RN80W56Ga9WkNBRlZmWUtiaU0

Visual: 
https://drive.google.com/a/mozilla.com/folderview?id=0B4K8q1qWmtAvdUJFYUx5NFBEaVk&usp=sharing&tid=0B2-G3kew1WpXLURNc29vTWl5eUk

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:TV_FTE_system > mozilla-b2g:master

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8683035 [details] [review]
[gaia] rexboy7:TV_FTE_system > mozilla-b2g:master

Hi luke:
This patch tries to show FTE on context menu with pin-to-home menu item. May you help to review it? Thanks a lot.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8683035 [details] [review]
[gaia] rexboy7:TV_FTE_system > mozilla-b2g:master

Good job! Thanks.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/25ba49d83214883808d3a6c59599a11c267057c3

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8683035 [details] [review]
[gaia] rexboy7:TV_FTE_system > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: Absence of first-time use in context menu with pin-to-card item.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): middle
[String changes made]: Yes

This is a subitem of blocker bug 1205944, so it should be a blocker.

Comment 6

[Mahendra Potharaju [:mahe]]

Josh, 

Can this land independent of other bugs in 1205944? Or wait until all others are complete?

Comment 7

[Mahendra Potharaju [:mahe]]

Comment on attachment 8683035 [details] [review]
[gaia] rexboy7:TV_FTE_system > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 8

[Carsten Book [:Tomcat]]

2.5 https://github.com/mozilla-b2g/gaia/commit/0d0ebbcf7b8e253c29282e783bb2db0588d120da

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Since this is in TV apps folder, I believe we don't need the late-l10n tag here.