1220608 - As a desktop client user in a sharing session, I can pause/restart sharing my tabs

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

The design here seems potentially confusing/surprising:

Both the pause and stop button are on an infobar containing the following text:

"You are sharing your tabs; any tab you click on can be seen by your friend."

In that context, "pause" does what I would expect: it pauses the tab sharing.

However, "stop" terminates both the tab-sharing and the audio & video, which seems surprising, given that the infobar text only talks about tabs.

Thoughts?

Comment 2

[Marco Castelluccio [:marco]]

I was confused as well.

I guess it's more confusing if you have already used Hello in the past (I have).

Comment 3

[Pau Masiá [:Pau]]

Yes Dan, it can be confusing if you've used Hello in the past since the approach was completely different. 
This "Stop" button acts as the "Leave" one we had in previous versions of Hello so users don't have to be confused about what will happen if they click on it.

For now, I think a possible solution would be to change that copy to be clear on what action that button performs. I would suggest going back to the "Leave" copy we had since it's clear enough for the users.

Comment 4

[Romain Testard [:RT]]

Sounds OK to me.
Matej, is this fine with you?

Comment 5

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1220608 > mozilla:master

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8706334 [details] [review]
[loop] mancas:bug1220608 > mozilla:master

Hey Mark, this is a first approach for the pause/resume feature. As you suggested on irc, I'm using the same method, to "pause" the screen share, as we use to mute audio/video.

Please take a look. Thanks

Comment 7

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #4)
> Sounds OK to me.
> Matej, is this fine with you?

I think I mentioned this in another bug a while back, but I find the notion of "pausing" confusing in this context. Sharing tabs is going to be something new for most users and it isn't the kind of action you consider being able to pause. And as mentioned in comment 1, I'm not sure it would be clear to me what the difference between Pause and Stop is.

Making the buttons something like Pause and Disconnect would help, but there's still a lot the user has to infer about the meaning of the word Pause in this context.

Maybe something like "Unshare" and "Disconnect" instead?

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

"Stop Sharing" for the first button would be another option...

Comment 9

[Manuel Casas Barrado [:mancas]]

Attachment: Demo

Comment 10

[Gervase Markham [:gerv]]

I'd go for "Stop Sharing" and "End Session"/"End Call".

I'd assume that sharing is on a per-tab basis. (Anything else could be unpleasantly surprising.) If so, there are always plenty of unshared tabs; presumably each would have a "Share This Tab" button while you are in a call.

Gerv

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8706334 [details] [review]
[loop] mancas:bug1220608 > mozilla:master

I've just tested this and it works well, just as we expected it to.

The code is using the constructs I'd expect so I'm giving this f+.

I'm going to leave the full review to someone else though as I'm a bit overloaded at the moment.

Comment 12

[Romain Testard [:RT]]

(In reply to Matej Novak [:matej] from comment #7)
> (In reply to Romain Testard [:RT] from comment #4)
> > Sounds OK to me.
> > Matej, is this fine with you?
> 
> I think I mentioned this in another bug a while back, but I find the notion
> of "pausing" confusing in this context. Sharing tabs is going to be
> something new for most users and it isn't the kind of action you consider
> being able to pause. And as mentioned in comment 1, I'm not sure it would be
> clear to me what the difference between Pause and Stop is.
> 
> Making the buttons something like Pause and Disconnect would help, but
> there's still a lot the user has to infer about the meaning of the word
> Pause in this context.
> 
> Maybe something like "Unshare" and "Disconnect" instead?

We agreed on the strings on bug 1211351 and then implemented the strings through bug 1213844
I'd propose "Stop sharing" / "Restart sharing" and "Leave" (session feels too technical).

We'd have to align the current panel button "Stop sharing your tabs" and relabel it "Leave" for consistency.
Also "Tab sharing is paused" would become "Tab sharing is stopped"

Recap of strings:
- Panel Button label: "Browse this page with a friend", "Leave"
- Infobar string: You are sharing your tabs. Any tab you click on can be seen by your friends" "Tab sharing is stopped"
- Infobar buttons: "Stop sharing" "Leave" "Restart sharing"
- Conversation window strings: "Tab sharing is stopped" 

Matej, does this seem OK?

Comment 13

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #12)
> (In reply to Matej Novak [:matej] from comment #7)
> > (In reply to Romain Testard [:RT] from comment #4)
> > > Sounds OK to me.
> > > Matej, is this fine with you?
> > 
> > I think I mentioned this in another bug a while back, but I find the notion
> > of "pausing" confusing in this context. Sharing tabs is going to be
> > something new for most users and it isn't the kind of action you consider
> > being able to pause. And as mentioned in comment 1, I'm not sure it would be
> > clear to me what the difference between Pause and Stop is.
> > 
> > Making the buttons something like Pause and Disconnect would help, but
> > there's still a lot the user has to infer about the meaning of the word
> > Pause in this context.
> > 
> > Maybe something like "Unshare" and "Disconnect" instead?
> 
> We agreed on the strings on bug 1211351 and then implemented the strings
> through bug 1213844
> I'd propose "Stop sharing" / "Restart sharing" and "Leave" (session feels
> too technical).
> 
> We'd have to align the current panel button "Stop sharing your tabs" and
> relabel it "Leave" for consistency.
> Also "Tab sharing is paused" would become "Tab sharing is stopped"
> 
> Recap of strings:
> - Panel Button label: "Browse this page with a friend", "Leave"
> - Infobar string: You are sharing your tabs. Any tab you click on can be
> seen by your friends" "Tab sharing is stopped"
> - Infobar buttons: "Stop sharing" "Leave" "Restart sharing"
> - Conversation window strings: "Tab sharing is stopped" 
> 
> Matej, does this seem OK?

Since we're not talking about conversations anymore, "Leave" doesn't feel right. I agree that "session" sounds technical, but I think we have the say something like "Disconnect."

Comment 14

[Romain Testard [:RT]]

OK, sounds good to me!

So the strings we want are:
- Panel Button label: "Browse this page with a friend", "Disconnect"
- Infobar string: You are sharing your tabs. Any tab you click on can be seen by your friends" "Tab sharing is stopped"
- Infobar buttons: "Stop sharing" "Disconnect" "Restart sharing"
- Conversation window strings: "Tab sharing is stopped"

Comment 15

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #14)
> OK, sounds good to me!
> 
> So the strings we want are:
> - Panel Button label: "Browse this page with a friend", "Disconnect"
> - Infobar string: You are sharing your tabs. Any tab you click on can be
> seen by your friends" "Tab sharing is stopped"
> - Infobar buttons: "Stop sharing" "Disconnect" "Restart sharing"
> - Conversation window strings: "Tab sharing is stopped"

Seeing it again, the one that stands out is "Tab sharing is stopped." It feels a little awkward grammatically. Could it be something like "Tab sharing has been stopped" or "You are no longer sharing your tab"?

Comment 16

[Romain Testard [:RT]]

"You are no longer sharing your tabs" seems appropriate to me.

If we're all good with that, recap of the strings:
- Panel Button label: "Browse this page with a friend", "Disconnect"
- Infobar string: You are sharing your tabs. Any tab you click on can be
> seen by your friends" "You are no longer sharing your tabs"
- Infobar buttons: "Stop sharing" "Disconnect" "Restart sharing"
- Conversation window strings: "You are no longer sharing your tabs"

Comment 17

[Mike de Boer [:mikedeboer]]

Comment on attachment 8706334 [details] [review]
[loop] mancas:bug1220608 > mozilla:master

Looking good, thanks! I'd like to see one more round with the changes I requested.

Comment 18

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8706334 [details] [review]
[loop] mancas:bug1220608 > mozilla:master

Changes already done so ready for another round.

Thanks!

Comment 19

[Mike de Boer [:mikedeboer]]

Comment on attachment 8706334 [details] [review]
[loop] mancas:bug1220608 > mozilla:master

Works as advertised! Thanks! r=me with the one comment addressed.

Comment 20

[Manuel Casas Barrado [:mancas]]

Romain, we should update the strings in this bug or you're planning to open a follow-up to do that?

Comment 21

[Mark Banner (:standard8)]

(In reply to Manuel Casas Barrado [:mancas] from comment #20)
> Romain, we should update the strings in this bug or you're planning to open
> a follow-up to do that?

Please can we do it in a follow-up. Since this has got r+ we should land it.

Comment 23

[Romain Testard [:RT]]

The strings can be done on bug 1239634

Comment 24

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla/loop/commit/78c8443baff2fbfcb2d6a9c7e03879722589cceb