Closed Bug 1220631 Opened 4 years ago Closed 4 years ago

Enable media mochitest on emu-x86-kk, Treeherder Production

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla45

People

(Reporter: bwu, Assigned: bwu)

References

Details

Attachments

(2 files, 1 obsolete file)

We need this to enable media mochitest.
Summary: Enable mochitest on emu-x86-kk, Treeherder Production → Enable media mochitest on emu-x86-kk, Treeherder Production
grandt, 
I don't know automation any bit, but I really want to enable media mochitest on emulator kk. 
Could you help me check this patch if it is correct or not?
Thanks!
Attachment #8682495 - Flags: feedback?(garndt)
Treeherder: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6a6509f5b7c
Don't know why it fails... :(
Comment on attachment 8682495 [details] [diff] [review]
Bug-1220631-Enable-media-mochitest-on-emu-x86-kk-Tre.patch

This patch does seem like it would add it to all branches that inherit from base_jobs (which I think is most of them at this point).  As far as reporting to production, I would just check with sheriffs because I'm not sure what set of things they are sheriffing that gets reported there but if this is added to TH prod, and sheriffs are managing it, it could get hidden pretty quick if it's orange.  I'm also unsure why we are using the group symbol of "tc-M".  As far as I understand it, x86 is only run on taskcluster, so there is no need to prefix this group with "tc" since there is not a buildbot job we're trying to separate it from (but that's an issue for a different bug)
Attachment #8682495 - Flags: feedback?(garndt) → feedback+
Currently B2G-KK-Emulator-x86-opt is more stable than B2G-KK-Emulator-x86-debug, so enable mochitests on the opt one.
Assignee: nobody → bwu
Status: NEW → ASSIGNED
Attachment #8687791 - Flags: review?(garndt)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=121ccbdd7754
Once the patch gets r+, I plan to ask sheriffs to hide those orange chunk.
Then we can continue to fix those failures and enable them in the future.
Comment on attachment 8687791 [details] [diff] [review]
Bug-1220631-Enable-mochitest-on-emu-x86-kk-Treeherde.patch

Review of attachment 8687791 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8687791 - Flags: review?(garndt) → review+
(In reply to Greg Arndt [:garndt] from comment #6)
> Comment on attachment 8687791 [details] [diff] [review]
> Bug-1220631-Enable-mochitest-on-emu-x86-kk-Treeherde.patch
> 
> Review of attachment 8687791 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me.
Thanks for your review!
Carry r+ from garndt.
Attachment #8687791 - Attachment is obsolete: true
Attachment #8688119 - Flags: review+
Sheriffs,
This patch (attachment 8688119 [details] [diff] [review]) is to enable mochitest on B2G-KK-Emulator-x86-opt. We know there are some failures, but we cannot wait all to be fixed and then enable it, so could you help hide those failures? We will try to fix those failures and enable them in the future.
Keywords: checkin-needed
Tomcat, 
FYI. This is what was discussed in the mail "Enable Emulator KK" with Josh and Hsinyi.
Flags: needinfo?(cbook)
Ryan, 
Per comment 5 and comment 11, could you help it?
Flags: needinfo?(ryanvm)
I have no context on this and I haven't been an active sheriff in over two months. I think Tomcat and/or KWierso need to own this.
Flags: needinfo?(ryanvm)
Hi Blake, btw which tests need to be hidden ?
Flags: needinfo?(cbook)
I've hidden tc-m(14,29,30,31,34) on all trunk branches and try (so you'll need to show hidden jobs to see if you've fixed them).
It's possible some of these chunks are just intermittent instead of permafailing, but those can be re-shown later.
Okay, hid a bunch more chunks that were frequently failing.
(In reply to Carsten Book [:Tomcat] from comment #14)
> Hi Blake, btw which tests need to be hidden ?
All the failures :)
Thanks!
https://hg.mozilla.org/mozilla-central/rev/16e98ad8c97b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
(In reply to Blake Wu [:bwu][:blakewu] from comment #18)
> (In reply to Carsten Book [:Tomcat] from comment #14)
> > Hi Blake, btw which tests need to be hidden ?
> All the failures :)
> Thanks!

Hi Blake, since a lot of tests are hidden now, is there any progress on this ? since there is a effort to enable such tests too ?
Flags: needinfo?(bwu)
(In reply to Carsten Book [:Tomcat] from comment #20)
> (In reply to Blake Wu [:bwu][:blakewu] from comment #18)
> > (In reply to Carsten Book [:Tomcat] from comment #14)
> > > Hi Blake, btw which tests need to be hidden ?
> > All the failures :)
> > Thanks!
> 
> Hi Blake, since a lot of tests are hidden now, is there any progress on this
> ? since there is a effort to enable such tests too ?
Benjamin, 
Could you answer Tomcat's question?
Thanks!
Flags: needinfo?(bwu) → needinfo?(bechen)
Flags: needinfo?(bechen)
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.