1220682 - Error handling in nsAutoJSString::init (the single-arg version) is busted

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It does:

332   return init(nsContentUtils::RootingCxForThread(), v);

but the two-arg init() can throw OOM exceptions as far as I can tell, and this code will leave those dangling.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Clear exceptions on single-arg init. v1

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8682584 [details] [diff] [review]
Clear exceptions on single-arg init. v1

r=me

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21c99c452631

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21c99c452631

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/21c99c452631