Closed Bug 1220682 Opened 8 years ago Closed 8 years ago

Error handling in nsAutoJSString::init (the single-arg version) is busted

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: bzbarsky, Unassigned)

References

Details

Attachments

(1 file)

Clear exceptions on single-arg init. v1
844 bytes, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
It does:

332   return init(nsContentUtils::RootingCxForThread(), v);

but the two-arg init() can throw OOM exceptions as far as I can tell, and this code will leave those dangling.
Flags: needinfo?(huseby)
Flags: needinfo?(bobbyholley)
Component: Build Config → DOM
Comment on attachment 8682584 [details] [diff] [review]
Clear exceptions on single-arg init. v1

r=me
Attachment #8682584 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/21c99c452631
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Flags: needinfo?(huseby)
Flags: needinfo?(bobbyholley)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.