Closed
Bug 1220703
Opened 9 years ago
Closed 9 years ago
Remove AutoDisableStoreBuffer
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.44 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
When we landed GGC several years ago, many trace functions were tripping barriers, so for expedience I just disabled post barriers globally during GC. It seems in the meantime we've largely or completely fixed this as we are passing jit and js shell tests locally without the AutoDisableStoreBuffer -- note: the isHeapBusy test is still present in StoreBuffer::put. I'll do a try run to verify that this is also true for the browser and flag review if it's green.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ac4120d1100
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8682004 [details] [diff] [review] 65_remove_AutoDisableStoreBuffer-v0.diff Seems green enough in the browser too.
Attachment #8682004 -
Flags: review?(jcoppeard)
Comment 3•9 years ago
|
||
Comment on attachment 8682004 [details] [diff] [review] 65_remove_AutoDisableStoreBuffer-v0.diff Review of attachment 8682004 [details] [diff] [review]: ----------------------------------------------------------------- Great! As you say we assert this in StoreBuffer::put() so it looks like this can go.
Attachment #8682004 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/835785b85db2f1c1392c4448f5a64082483dbfa4 Bug 1220703 - Remove AutoDisableStoreBuffer; r=jonco
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/835785b85db2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•