1220748 - Enable browser_permissionsPromptDeny.js in e10s

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Andrew McCreight [:mccr8]]

This test current fails in e10s on this line:
  gBrowser.selectedBrowser.docShell.QueryInterface(Ci.nsILoadContext).usePrivateBrowsing = true;

With this error: "TypeError: gBrowser.selectedBrowser.docShell is null"

I don't know if this is the best way to do this, but I found a place in browser/components/privatebrowsing/test/browser/browser_privatebrowsing_concurrent.js that sets usePrivateBrowsing by doing ContentTask.spawn (in the function setUsePrivateBrowsing). The main drawback is that the test will have to be reworked to use generators.

Comment 1

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=903e81ff84a8

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Try seems green (I haven't seen Windows results yet as there's currently about 2000 pending test jobs on that platform).

I'm disappointed that I had to use a different code path for e10s and non-e10s to get the test to pass. If I use the ContentTask to set usePrivateBrowsing to true on non-e10s, my message event listener never gets triggered, despite the window.parent.postMessage function being called. I haven't been able to figure out why. Still seems better than having this test disabled on e10s though :).

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8723630 [details] [diff] [review]
Patch

Review of attachment 8723630 [details] [diff] [review]:
-----------------------------------------------------------------

indeed, that's strange.. oh well, having the test running is always better

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/008d7f4d10bf9694b2dc3bdd3568575e22cdbf6a
Bug 1220748 - Enable browser_permissionsPromptDeny.js in e10s, r=felipe.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/008d7f4d10bf