Closed Bug 1220748 Opened 4 years ago Closed 4 years ago

Enable browser_permissionsPromptDeny.js in e10s

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
e10s + ---
firefox45 --- affected
firefox47 --- fixed

People

(Reporter: mccr8, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This test current fails in e10s on this line:
  gBrowser.selectedBrowser.docShell.QueryInterface(Ci.nsILoadContext).usePrivateBrowsing = true;

With this error: "TypeError: gBrowser.selectedBrowser.docShell is null"

I don't know if this is the best way to do this, but I found a place in browser/components/privatebrowsing/test/browser/browser_privatebrowsing_concurrent.js that sets usePrivateBrowsing by doing ContentTask.spawn (in the function setUsePrivateBrowsing). The main drawback is that the test will have to be reworked to use generators.
Blocks: e10s-tests
tracking-e10s: --- → +
Attached patch PatchSplinter Review
Try seems green (I haven't seen Windows results yet as there's currently about 2000 pending test jobs on that platform).

I'm disappointed that I had to use a different code path for e10s and non-e10s to get the test to pass. If I use the ContentTask to set usePrivateBrowsing to true on non-e10s, my message event listener never gets triggered, despite the window.parent.postMessage function being called. I haven't been able to figure out why. Still seems better than having this test disabled on e10s though :).
Attachment #8723630 - Flags: review?(felipc)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8723630 [details] [diff] [review]
Patch

Review of attachment 8723630 [details] [diff] [review]:
-----------------------------------------------------------------

indeed, that's strange.. oh well, having the test running is always better
Attachment #8723630 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/fx-team/rev/008d7f4d10bf9694b2dc3bdd3568575e22cdbf6a
Bug 1220748 - Enable browser_permissionsPromptDeny.js in e10s, r=felipe.
https://hg.mozilla.org/mozilla-central/rev/008d7f4d10bf
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.