Closed Bug 1220752 Opened 4 years ago Closed 4 years ago

Fix for e10s browser_bug1058164.js now that bug 918634 has landed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: mccr8, Unassigned)

References

Details

Attachments

(1 file)

The test for bug 1058164 is disabled on e10s. The comment said it is waiting for bug 918634, but that has landed now.
Can you look into fixing this, Mike? Thanks.
Flags: needinfo?(mconley)
FWIW the failures I see locally when running this are:
19 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_bug1058164.js | Timed out waiting for pagehide - 
Stack trace:
chrome://mochitests/content/browser/dom/base/test/browser_bug1058164.js:prepareForPageEvent/</timeoutId<:38
20 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_bug1058164.js | Uncaught exception - 
21 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_bug1058164.js | Timed out waiting for pageshow - 
Stack trace:
chrome://mochitests/content/browser/dom/base/test/browser_bug1058164.js:prepareForPageEvent/</timeoutId<:38
22 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_bug1058164.js | Found an unexpected browser window at the end of test run -
I'll hopefully be able to get to this in the next few days. Leaving this on my needinfo list.
Comment on attachment 8693132 [details]
MozReview Request: Bug 1220752 - Fix for e10s browser_bug1058164.js now that bug 918634 has landed. r?mrbkap

https://reviewboard.mozilla.org/r/26411/#review24099
Attachment #8693132 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/3307a8018622
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.