Closed
Bug 1220779
Opened 9 years ago
Closed 9 years ago
Labels for Accessibility of Notifications should have consistent wording
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | unaffected |
| firefox44 | --- | wontfix |
| firefox45 | --- | fixed |
People
(Reporter: wmaggs, Assigned: lina)
Details
Attachments
(1 file)
Currently our language for permissions and preferences for Push is bases on the idea that a site can send notifications and a user can receive them. In on of other labels that may be read by a screenreader in https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#204 the string says : "Change whether the site can receive notifications" It should say: "Change whether the user can receive notifications from the site"
|
Assignee | |
Comment 1•9 years ago
|
||
Some of the other accessibility strings include "you," so it may be confusing to refer to the user in the third person here. How about "change whether you can receive notifications from the site," or "manage receiving notifications from the site" (to match auto-fill and WebRTC)?
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
"Change whether you can receive notifications from the site" works for me.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Bug 1220779 - Make the web notifications label match the permission doorhanger. r=MattN
Attachment #8682117 -
Flags: review?(MattN+bmo)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8682117 [details] MozReview Request: Bug 1220779 - Make the web notifications label match the permission doorhanger. r=MattN https://reviewboard.mozilla.org/r/23967/#review21629
Attachment #8682117 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e3a487def5b169e7ebfc7b8c41bba1f541931037 Bug 1220779 - Make the web notifications label match the permission doorhanger. r=MattN
|
|
Assignee | |
Updated•9 years ago
|
status-firefox43:
--- → unaffected
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Component: DOM: Push Notifications → General
Product: Core → Firefox
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e3a487def5b1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
|
|
||
Comment 7•9 years ago
|
||
wontfix for 44 due to string changes
|
||
Comment 8•9 years ago
|
||
One can always receive notifications if the site and browser support them and could block/disallow them which is quite different form "Change whether you can receive notifications from the site"… https://hg.mozilla.org/mozilla-central/diff/e3a487def5b1/browser/locales/en-US/chrome/browser/browser.dtd
You need to log in
before you can comment on or make changes to this bug.
Description
•