Don't install Jetpack test XPI files for builds that will never run Jetpack tests

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: nalexander, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Fennec and b2gdroid will never run the Mochitest Jetpack suite, at least I don't think we will, but we create a lot of XPI files at build time, which appears to take non-trivial time.

Can we make https://dxr.mozilla.org/mozilla-central/rev/96377bdbcdf3e444a22aeaa677da696243b00d98/addon-sdk/moz.build#14 conditional on the build type?
gbrown: do you know anything about this code?  Can you redirect?

Mossop: is there a hidden dependency that I don't know about here?  Is there a reason this isn't guarded by --disable-tests?
Flags: needinfo?(gbrown)
Flags: needinfo?(dtownsend)
(In reply to Nick Alexander :nalexander from comment #1)
> gbrown: do you know anything about this code?  Can you redirect?
> 
> Mossop: is there a hidden dependency that I don't know about here?  Is there
> a reason this isn't guarded by --disable-tests?

No reason at all, I just didn't know we still supported that build flag when I wrote that stuff.
Flags: needinfo?(dtownsend)
(In reply to Nick Alexander :nalexander from comment #1)
> gbrown: do you know anything about this code?  Can you redirect?

Sorry, I don't know much about Jetpack tests and am not sure where to redirect. Feel free to ping me again with any specific concerns.

I would suggest making that bit (Comment 0) conditional on platform, push it to try and see if anything breaks.
Flags: needinfo?(gbrown)
Gah!  Filed before profiling.  |mach build addon-sdk| prints a lot of noise around building .xpi files, but actually takes only 3s on my laptop.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.