Closed
Bug 1220822
Opened 9 years ago
Closed 9 years ago
Rewrite the nsINode::OwnerDoc comment to not contradict itself and relate it to HTML5 terms
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file, 1 obsolete file)
1.59 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8682143 -
Flags: review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jwatt
Comment 2•9 years ago
|
||
Comment on attachment 8682143 [details] [diff] [review] patch >+ * For all other cases (this node is nsIContent, not nsIDocument) GetOwnerDoc This is a bit oddly said, since not all other cases are nsIContent objects. (we have still nsIAttribute)
Assignee | ||
Comment 3•9 years ago
|
||
Removes parenthetical.
Attachment #8682143 -
Attachment is obsolete: true
Attachment #8682143 -
Flags: review?(amarchesini)
Attachment #8682150 -
Flags: review?(amarchesini)
Updated•9 years ago
|
Attachment #8682150 -
Flags: review?(amarchesini) → review+
Comment 5•9 years ago
|
||
+ * For all other cases GetOwnerDoc and GetOwnerDocument behave identically. What is that GetOwnerDoc you speak of above? Shouldn't it say: For all other cases OwnerDoc and ...
Flags: needinfo?(jwatt)
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/696ea2cdc032
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 7•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/696ea2cdc032
status-b2g-v2.5:
--- → fixed
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #5) > + * For all other cases GetOwnerDoc and GetOwnerDocument behave > identically. > > What is that GetOwnerDoc you speak of above? Shouldn't it say: > > For all other cases OwnerDoc and ... Thanks for noticing that! I took the liberty of using you as the reviewer. ;)
Flags: needinfo?(jwatt)
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5bcb60614d01
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•