Closed Bug 1220822 Opened 4 years ago Closed 4 years ago

Rewrite the nsINode::OwnerDoc comment to not contradict itself and relate it to HTML5 terms

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Attachment #8682143 - Flags: review?(amarchesini)
Assignee: nobody → jwatt
Comment on attachment 8682143 [details] [diff] [review]
patch

>+   * For all other cases (this node is nsIContent, not nsIDocument) GetOwnerDoc
This is a bit oddly said, since not all other cases are nsIContent objects.
(we have still nsIAttribute)
Attached patch patchSplinter Review
Removes parenthetical.
Attachment #8682143 - Attachment is obsolete: true
Attachment #8682143 - Flags: review?(amarchesini)
Attachment #8682150 - Flags: review?(amarchesini)
Attachment #8682150 - Flags: review?(amarchesini) → review+
+   * For all other cases GetOwnerDoc and GetOwnerDocument behave identically.

What is that GetOwnerDoc you speak of above?  Shouldn't it say:

For all other cases OwnerDoc and ...
Flags: needinfo?(jwatt)
https://hg.mozilla.org/mozilla-central/rev/696ea2cdc032
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
(In reply to Mats Palmgren (:mats) from comment #5)
> +   * For all other cases GetOwnerDoc and GetOwnerDocument behave
> identically.
> 
> What is that GetOwnerDoc you speak of above?  Shouldn't it say:
> 
> For all other cases OwnerDoc and ...

Thanks for noticing that! I took the liberty of using you as the reviewer. ;)
Flags: needinfo?(jwatt)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.