Closed
Bug 1220882
Opened 10 years ago
Closed 10 years ago
Use LazyLogModule in MP4Metadata
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
|
2.17 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Our rust calls in MP4Metadata.cpp log output as printf(). We should use LazyLogModule instead for proper, filterable output.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8682250 -
Flags: review?(kinetik)
|
||
Updated•10 years ago
|
Attachment #8682250 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
See also https://github.com/mozilla/mp4parse-rust/commit/83b7c38cb19ab4a50d5e045bfbec3b4febf3b286 which turns off the debug prints in MP4Metadata.rs.
|
||
Comment 4•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
|
||
Comment 5•10 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 6•10 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•