Closed Bug 1220882 Opened 5 years ago Closed 5 years ago

Use LazyLogModule in MP4Metadata

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Our rust calls in MP4Metadata.cpp log output as printf(). We should use LazyLogModule instead for proper, filterable output.
Attachment #8682250 - Flags: review?(kinetik)
Attachment #8682250 - Flags: review?(kinetik) → review+
See also https://github.com/mozilla/mp4parse-rust/commit/83b7c38cb19ab4a50d5e045bfbec3b4febf3b286 which turns off the debug prints in MP4Metadata.rs.
https://hg.mozilla.org/mozilla-central/rev/c00bd9bed225
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
You need to log in before you can comment on or make changes to this bug.