Closed Bug 1220884 Opened 4 years ago Closed 4 years ago

Friendlier strings for the notification upgrade UI

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox43 --- unaffected
firefox44 --- fixed
firefox45 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [strings])

Attachments

(1 file)

(Quoting Edwin Wong [:edwong] from bug 1217990 comment #28)
> Prod and UX agree on: 
> Title: Upgraded Notifications
> Body: You can now receive notifications from sites that are not currently
> loaded. Click to learn more.
Bug 1220884 - Friendlier string for the notification upgrade UI. r=kitcambridge
Attachment #8682219 - Flags: review?(kcambridge)
Attachment #8682219 - Flags: review?(kcambridge) → review+
Comment on attachment 8682219 [details]
MozReview Request: Bug 1220884 - Friendlier string for the notification upgrade UI. r=kitcambridge

https://reviewboard.mozilla.org/r/23997/#review21425

Looks good, pending property name change!

::: browser/locales/en-US/chrome/browser/browser.properties:388
(Diff revision 1)
> -webNotifications.upgradeInfo=You will receive notifications from sites, even those not open in a tab. Click to learn more.
> +webNotifications.upgradeBody=You can now receive notifications from sites that are not currently loaded. Click to learn more.

Does this need to be changed in `nsBrowserGlue.js`?
(In reply to Kit Cambridge [:kitcambridge] from comment #2)
> Does this need to be changed in `nsBrowserGlue.js`?

Oops, forgot to save that file. Good catch!
Comment on attachment 8682219 [details]
MozReview Request: Bug 1220884 - Friendlier string for the notification upgrade UI. r=kitcambridge

Bug 1220884 - Friendlier string for the notification upgrade UI. r=kitcambridge
http://hg.mozilla.org/releases/mozilla-aurora/rev/cb41b90cd72f

At this point we're way past the normal string-freeze date, so please go through the standard mozilla-aurora approval if there are other changes.
https://hg.mozilla.org/mozilla-central/rev/4f88fc3bd332
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
(In reply to Francesco Lodolo [:flod] from comment #6)
> At this point we're way past the normal string-freeze date,

It's normally Monday into Tuesday so this was at most a few hours late.

> so please go through the standard mozilla-aurora approval if there are other changes.

There are no others and I only landed that because I believed we were within the normal pre-freeze time.
You need to log in before you can comment on or make changes to this bug.