Add layerviewer for layer tree & display list visualization

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8682208 [details] [diff] [review]
patch

I already wrote this tool in cleopatra. Let's make it work standalone similar to reftest analyzer and check it into the gfx module as a testing tool.
Attachment #8682208 - Flags: review?(botond)
(Assignee)

Updated

3 years ago
Assignee: nobody → bgirard
(Assignee)

Comment 1

3 years ago
dvander I know you have something similar. How do we reconcile this into a tool for everyone?
Flags: needinfo?(dvander)
Comment on attachment 8682208 [details] [diff] [review]
patch

Review of attachment 8682208 [details] [diff] [review]:
-----------------------------------------------------------------

I like the idea of getting this into the tree! 

However, this is currently not working for me: when I press "Process pasted log" on the pre-populated example layer dump, I just get an empty rectangle as a result. Dropping review flag until we clear this up and get it working.

::: gfx/layers/layerviewer/index.html
@@ +7,5 @@
> +    <script src="layerTreeView.js"></script>
> +    <style>
> +body {
> +  /* Tooltip cause scrollbars */
> +  overflow: hidden;

For my screen size and zoom setting, the line "Help: To get a layers dump go to ..." is offscreen and I can't scroll to bring it into view. I would prefer that the page remain scrollable.
Attachment #8682208 - Flags: review?(botond)
The tool I've got is here: http://people.mozilla.org/~danderson/layers/

The features it has are: (1) It's offline, (2) You can simplify/hide layers to see occlusion, (3) It can show event regions/masks, (4) It will parse and pretty-print a gecko log so you can step frame by frame.

It doesn't read texture dumps or show display lists/client layers since it's sorta specialized for debugging APZ problems.

I don't know whether it's worth trying to reconcile them, aside from maybe having a common parser.
Flags: needinfo?(dvander)
Comment on attachment 8682208 [details] [diff] [review]
patch

Review of attachment 8682208 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Botond Ballo [:botond] from comment #2)
> However, this is currently not working for me: when I press "Process pasted
> log" on the pre-populated example layer dump, I just get an empty rectangle
> as a result. Dropping review flag until we clear this up and get it working.

Ok, it turns out I just don't know how to use the tool. You have to click on the "LayerTree 1" text to show the layer tree! :)

On the one hand, silly me! On the other hand, I think this shows that the UI should be doing something to suggest that you need to do that - either making that a button instead of just text, or adding a label that says "click on one of the frames in this list", or pre-selecting the 

r+ with this, and the scrolling issue, addressed.

(In terms of the actual js code of the tool, this is mostly a rubber-stamp. As you said, it's probably not worth going through that line by line.)
Attachment #8682208 - Flags: review+
(Assignee)

Comment 5

3 years ago
Created attachment 8683864 [details] [diff] [review]
patch
Attachment #8682208 - Attachment is obsolete: true
Attachment #8683864 - Flags: review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6617d9d50344d112794735908c60c1af69d6ad52
Bug 1220895 - Add layerviewer for layer tree & display list visualization NPOTB. r=botond

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6617d9d50344
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.