1220910 - Land preventative changes (e.g. Nightly flag) if shareplane in top level doesn't make 45

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

bug 1217174 will implement a better flow for the user when they are not ready to share. However, if we aren't able to implement that in time, we have to either:
  1) Backout of 45
  2) Implement a Nightly flag
  3) Hide the share plane when the user isn't ready to share (i.e. fix bug 1219999)

1) is feasible, but could get more messy as we land more code over it. 2) is *a lot* of work because the code we ripped out to put the share plane in the share menu is very complex. 3) takes a little effort but is fairly straight-forward – a prototype patch is available.

I'd vote for #3.

Tracking 45 to make sure we either do this, or land the improved UI (bug 1217174) by 45.

Top level share plane originally implemented in bug 1140048.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Margaret, if you don't think it's worth prioritizing the better flow right now (bug 1217174), let me know and I'll just implement one of these directly.

It could be worth evaluating alternative onboarding approaches to the share plane that could be more effective, or just less work.

Comment 2

[:Margaret Leibovic]

I defer product priority questions to Barbara, but I'm generally in favor of doing whatever is simplest.

If option #3 isn't too hard, I would rather just implement that to get the product into a decent shape to ship what we have now in 45, then we can work on bug 1217174 without stressing over landing it for 45 as well.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Expected UI

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

After talking with Barbara & antlam (bug 1217174 comment 8), we're going to ship in 45 or back it out: WONTFIX.