Closed Bug 1220916 Opened 9 years ago Closed 9 years ago

"WARNING: TimelineConsumers could not be initialized" when running gtests

Categories

(DevTools :: Memory, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: fitzgen, Assigned: vporof)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Running the heap snapshot gtests:

> $ ./mach gtest DevTools.*

Results in this warning:

> [33896] WARNING: TimelineConsumers could not be initialized.: file /Users/fitzgen/src/mozilla-central/docshell/base/timeline/TimelineConsumers.cpp, line 63

We shouldn't get warnings when running passing tests normally.
That error is harmless. This happens when TimelineConsumers wants to be initialized while the application is shutting down. In this state, there's many things that aren't accessible, so we bailout, but print that just for reference. Is there anything else better than NS_WARNING for this case?
If it is harmless, then why bother warning? To me, it is just clutter in my test logs.
Alright, let's remove it.
Has STR: --- → yes
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8683078 - Flags: review?(nfitzgerald)
Comment on attachment 8683078 [details] [diff] [review]
v1

Review of attachment 8683078 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Thanks!
Attachment #8683078 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/112b9579890a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: