Closed
Bug 1220916
Opened 9 years ago
Closed 9 years ago
"WARNING: TimelineConsumers could not be initialized" when running gtests
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: fitzgen, Assigned: vporof)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.58 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Running the heap snapshot gtests: > $ ./mach gtest DevTools.* Results in this warning: > [33896] WARNING: TimelineConsumers could not be initialized.: file /Users/fitzgen/src/mozilla-central/docshell/base/timeline/TimelineConsumers.cpp, line 63 We shouldn't get warnings when running passing tests normally.
Assignee | ||
Comment 1•9 years ago
|
||
That error is harmless. This happens when TimelineConsumers wants to be initialized while the application is shutting down. In this state, there's many things that aren't accessible, so we bailout, but print that just for reference. Is there anything else better than NS_WARNING for this case?
Reporter | ||
Comment 2•9 years ago
|
||
If it is harmless, then why bother warning? To me, it is just clutter in my test logs.
Assignee | ||
Comment 3•9 years ago
|
||
Alright, let's remove it.
Reporter | ||
Updated•9 years ago
|
Has STR: --- → yes
Reporter | ||
Updated•9 years ago
|
Blocks: memory-testing
Assignee | ||
Comment 4•9 years ago
|
||
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8683078 [details] [diff] [review] v1 Review of attachment 8683078 [details] [diff] [review]: ----------------------------------------------------------------- \o/ Thanks!
Attachment #8683078 -
Flags: review?(nfitzgerald) → review+
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/112b9579890a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•