1220942 - Add 2.5 to 2.6 FTU tutorial config

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Sam Foster [:sfoster] (he/him)]

As people get updates from 2.5 to 2.6 they will be directed to the FTU tutorial. Without any specific details all the steps will be shown. We should add placeholder config to apps/ftu/config/tiny.json for this scenario (probably 0 steps / empty array)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:ftu-2dot6-config-bug-1220942 > mozilla-b2g:master

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8683260 [details] [review]
[gaia] sfoster:ftu-2dot6-config-bug-1220942 > mozilla-b2g:master

This shouldn't affect any tests, but I'll watch treeherder anyhow before trying to merge. An update from 2.2 or 2.5 to current master (2.6) should result in just the FTU's finish/yay you updated screen, with no video tutorial steps to show.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Why wouldn't we also support upgrading from 2.1, since it was equally empty from 2.1 to 2.5? Not supporting it here means we show all the tutorial steps? Seem like an easy fix. I have the same question about 2.0 to 2.6.

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Michael Henretty [:mhenretty] from comment #3)
> Why wouldn't we also support upgrading from 2.1, since it was equally empty
> from 2.1 to 2.5? Not supporting it here means we show all the tutorial
> steps? Seem like an easy fix. I have the same question about 2.0 to 2.6.

It was a decision we took (UX, Product) around 2.1 I think to stop the number of upgrade permutations ever ballooning. I'm happy to add back the empty steps for 2.0 and 2.1 if we think that would result in a better experience.

Comment 5

[Sam Foster [:sfoster] (he/him)]

> It was a decision we took (UX, Product) around 2.1 I think to stop the
> number of upgrade permutations ever ballooning. I'm happy to add back the
> empty steps for 2.0 and 2.1 if we think that would result in a better
> experience.

I have updated the PR to make it so.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8683260 [details] [review]
[gaia] sfoster:ftu-2dot6-config-bug-1220942 > mozilla-b2g:master

Ah makes sense. Down the road it would be cool to add some logic that says, well if 2.0..2.6 has not steps than neither does 2.1..2.6, 2.2..2.6, etc. Anyway, this works for now.

Comment 7

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/cc611b6ef0dec9c87dfc6eeaf32e8bce0b2ec2a1

Some GU2 unit test failures - are in calendar and unrelated this patch.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Since the proposal calls for 2.6 not being upgradable, removing this as a test case.