1220978 - migrate Bluetooth to use NotificationHelper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[heidi.kasemir]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hkasemir:1220978-Bluetooth-notificationhelper > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8682324 [details] [review]
[gaia] hkasemir:1220978-Bluetooth-notificationhelper > mozilla-b2g:master

Shawn, I got a new hacker helping me with bug 1111841 which will make our notifications l10n aware.
The tests are green.

Can you review this?

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8682324 [details] [review]
[gaia] hkasemir:1220978-Bluetooth-notificationhelper > mozilla-b2g:master

Hi Fred,
This looks like your area. Can you review this patch?

Comment 4

[[e-mail]]

Comment on attachment 8682324 [details] [review]
[gaia] hkasemir:1220978-Bluetooth-notificationhelper > mozilla-b2g:master

looks good except 2 nits about trailing spaces

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Heidi, when you have a chance, please, apply Fred's feedback, squash your commits into a single one[*] and put 'checkin-needed' in keywords. Thank you!


[*] http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/f3c4a0f7ff031a836e69f7463df44e92313bf12a

Comment 8

[[e-mail]]

Not sure if related, but sometimes I got log error with the following steps

1. choose a image to share in gallery
2. select bluetooth
3. got log error `L10nError: Context not ready`

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

It shouldn't be. The only thing that I know that causes this error is use of mozL10n.get and in this bug we just removed a bunch of those calls :)

There are still 31 calls to mozL10n.get in bluetooth and I plan to remove them in this cycle, that should get rid of this message since all other APIs are async are non-racy.

If you want to find what causes it, go to shared/js/l10n.js, line 1370 and add "var e = new Error(); console.log(e.stack);".

This will tell you where mozL10n.get has been called from and this place is probably called before mozL10n is ready (you need to wrap it in mozL10n.once)

Comment 10

[[e-mail]]

Thanks for insight :)