Closed
Bug 1220996
Opened 9 years ago
Closed 9 years ago
Catch before/after key events for non-mozbrowser iframes in smart-system
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect, P3)
Tracking
(b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: cynthiatang, Assigned: yifan)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
rexboy
:
review+
mpotharaju
:
approval-gaia-v2.5+
|
Details | Review |
commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0 Merge: 06de78d e7dd557 Author: gasolin <gasolin@gmail.com> Date: Tue Nov 3 13:37:26 2015 +0800 STR: 1. Launch Browser 2. Go to Browser Setting 3. Select Sign in to Sync and press OK 4. Press Home Actual Result: - The user cannot go back to home screen Expected Result: - The user can go back to home screen
|
Reporter | |
Updated•9 years ago
|
QA Whiteboard: [COM=TV Firefox Account]
|
||
Comment 1•9 years ago
|
||
This is probably because we are not handling the HOME key on the FxA flow. YiFan, could you take a look at this, please?
Flags: needinfo?(yliao)
|
|
||
Updated•9 years ago
|
|
Assignee | |
Comment 2•9 years ago
|
||
Yes, thank you for noticing this!
Assignee: nobody → yliao
Status: NEW → ASSIGNED
Flags: needinfo?(yliao)
|
|
Assignee | |
Comment 3•9 years ago
|
||
According to https://bugzilla.mozilla.org/show_bug.cgi?id=1014418#c32 , the smart-system needs the 'before-after-keyboard-event' permission to catch home button press on a non-mozbrowser iframe.
Component: Gaia::TV::Browser → Gaia::TV::System
See Also: → 1014418
Summary: [TV Browser] User cannot go to Home screen from the Firefox Account - Sign in page → Catch before/after key events for non-mozbrowser iframes in smart-system
|
||
Comment 4•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8683497 -
Flags: review?(rexboy)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8683497 [details] [review] [gaia] begeeben:1220996_user_cannot_go_to_home > mozilla-b2g:master Looks good to me.
Attachment #8683497 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d9e3e3bc529221db6793cb9b116059070a65a287
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8683497 [details] [review] [gaia] begeeben:1220996_user_cannot_go_to_home > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1194108 [User impact] if declined: Pressing back key on the remote control will has no effect at certain dialogs. [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7281c8685773bb354bbbb8037eede00d4ec22954 [Risk to taking this patch] (and alternatives if risky): none [String changes made]: none
Attachment #8683497 -
Flags: approval-gaia-v2.5?
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8683497 [details] [review] [gaia] begeeben:1220996_user_cannot_go_to_home > mozilla-b2g:master Approved to uplift to 2.5 Thanks
Attachment #8683497 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 9•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/ccb8b75e3d53f55de9656f10c3775d90058369e1 for 2.5
status-b2g-v2.5:
--- → fixed
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
|
|
Reporter | |
Comment 10•8 years ago
|
||
Verify: ========= Master: Passed =================== gaia: https://github.com/mozilla-b2g/gaia/commit/77c0e08caa0dda8c6e50f6e7cbad9f79b320a3b0 gecko: https://hg.mozilla.org/mozilla-central/rev/a1b94785b48437662c696c9143ed92639e9617b2 ========= v2.5: Passed =================== gaia: https://github.com/mozilla-b2g/gaia/commit/8a0d9deb2cd47df25750ed2c6820909e4feac3bb gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae919160ce8c6a6e9c6d86017b02e1345dea382d mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae919160ce8c6a6e9c6d86017b02e1345dea382d
You need to log in
before you can comment on or make changes to this bug.
Description
•