1221015 - [RTL][Contacts]Text on the E-mail button is still left-aligned.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: con_email.png.png

[1.Description]:
[RTL][Contacts][Aries kk_v2.6][Flame kk_v2.5&v2.6]Set your phone language to Arabic and launch Contacts, tap a contact which has E-mail information, observe the E-mail button, text on it is still left-aligned.
See attachment: con_email.png

[2.Testing Steps]: 
1. Set your phone language to Arabic and launch Contacts. 
2. Tap a contact which has E-mail information.
3. Observe the E-mail button. 

[3.Expected Result]: 
In step 3, text on the  E-mail button should be right-aligned.

[4.Actual Result]: 
In step 3, text on the  E-mail button is still left-aligned.

[5.Reproduction build]: 
Device: AriesKK_2.6[Affected]
Build ID               20151103000930
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9f69202d82752e093a653a8f15b0274e347db33a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151102.233051
Firmware Date          Mon Nov  2 23:30:58 UTC 2015
Bootloader             s1

Device: FlameKK_v2.6[Affected]
Build ID               20151102150204
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6275cd9c71b76891f6b6585dabc687bc443ab877
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.182914
Firmware Date          Mon Nov  2 18:29:28 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame_v2.5[Affected]
Build ID               20151102004502
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b6b410d4610da18f5e43750e67ed2c56a0c0f812
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.042848
Firmware Date          Mon Nov  2 04:29:02 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15396

Comment 1

[Josh Cheng [:josh]]

Hi Kaze,
Do you have any update to this bug?
Thanks

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] fabi1cazenave:buttons-bug1221015 > mozilla-b2g:master

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 8687035 [details] [review]
[gaia] fabi1cazenave:buttons-bug1221015 > mozilla-b2g:master

Francisco, can you have a look please?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8687035 [details] [review]
[gaia] fabi1cazenave:buttons-bug1221015 > mozilla-b2g:master

LGTM

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/8853a6e73b6b172ac97471cdb445e97f8d1cee08

Comment 6

[Shally Li（leave from Mozilla）]

Hi Autumn,

    Could you please help verify this bug?

Thank you very much.

Comment 7

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK Master and Flame KK Master 512mb by the STR in comment 0.

Actual results: Text on the E-mail button is right-aligned.

See attachment: Verified_Master_mail.png
Reproduce rate: 0/10

Device: Aries KK Master(Pass)
Build ID               20151130132518
Gaia Revision          702773bee0b70e479ccebe5e061f571e977bc376
Gaia Date              2015-11-30 02:51:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a18630f9ab42ddfde03ba8c7757a42069c48c7ed
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.124429
Firmware Date          Mon Nov 30 12:44:37 UTC 2015
Bootloader             s1

Device: Flame KK Master 512mb(Pass)
Build ID               20151130150225
Gaia Revision          702773bee0b70e479ccebe5e061f571e977bc376
Gaia Date              2015-11-30 02:51:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a18630f9ab42ddfde03ba8c7757a42069c48c7ed
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151130.184049
Firmware Date          Mon Nov 30 18:40:59 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 8

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Master_mail.png